refactor: 초대장 참석 여부 API 응답에 nickname 필드 추가 #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
yechan-kim
requested review from
1winhyun and
jwnnoh
and removed request for
1winhyun
Test Results67 tests 67 ✅ 2s ⏱️ Results for commit 9f164e4. ♻️ This comment has been updated with latest results. |
jwnnoh
reviewed
Feb 4, 2025
...ucture/persistence-db/src/main/kotlin/site/yourevents/guest/repository/GuestJPARepository.kt
Show resolved
Hide resolved
module-domain/src/main/kotlin/site/yourevents/guest/port/out/GuestPersistencePort.kt
Show resolved
Hide resolved
1winhyun
reviewed
Feb 4, 2025
module-domain/src/main/kotlin/site/yourevents/guest/port/out/GuestPersistencePort.kt
Show resolved
Hide resolved
module-domain/src/main/kotlin/site/yourevents/guest/port/in/GuestUseCase.kt
Outdated
Show resolved
Hide resolved
...ucture/persistence-db/src/main/kotlin/site/yourevents/guest/repository/GuestJPARepository.kt
Show resolved
Hide resolved
module-presentation/src/main/kotlin/site/yourevents/invitation/facade/InvitationFacade.kt
Outdated
Show resolved
Hide resolved
1winhyun
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✅ PR 유형
어떤 변경 사항이 있었나요?
✏️ 작업 내용
getOwnerNickname메서드명을findNicknameByInvitationIdAndMemberId로 변경하여, 코드의 재사용성 증가Not Found예외 처리 로직 추가nickname필드 추가AS-IS
TO-BE
테스트 코드 결과
🔗 관련 이슈
💡 추가 사항