Use java logger when loader logger api isn't available #159
Conversation
...ric-logger-api-v1/common/src/main/java/net/legacyfabric/fabric/impl/logger/LoggerHelper.java
Outdated
Show resolved
Hide resolved
# Conflicts: # gradle.properties
| /** | ||
| * Represents a boolean value which can be true, false or refer to a default value. | ||
| */ | ||
| public enum TriState { |
There was a problem hiding this comment.
wait why does this exist
There was a problem hiding this comment.
https://github.com/Legacy-Fabric/fabric/blob/main/legacy-fabric-api-base/common/src/main/java/net/legacyfabric/fabric/api/util/TriState.java exists already. I think sponge command api uses it
There was a problem hiding this comment.
logger-api was supposed to be a standalone module, and technically every module depends on it so... what should we do in this case?
There was a problem hiding this comment.
logger-api was supposed to be a standalone module, and technically every module depends on it so... what should we do in this case?
that's fine, logger api could depend on api base. could also move logger api into api base
There was a problem hiding this comment.
Hm, I know some projects that uses it outside of LegacyFabric too...
Supersedes #145
Should fix crash with Quilt even tho we don't officially support it.