Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Registry sync v2 - Item #168

Draft
wants to merge 42 commits into
base: feature/registry-sync-v2/main
Choose a base branch
from
Draft

Registry sync v2 - Item #168

wants to merge 42 commits into from

Conversation

thecatcore
Copy link
Member

@thecatcore thecatcore commented Mar 23, 2024 •
edited
Loading

Depends on #167.
For the real diff between #167 and this, see thecatcore#1

What does this module do:

  • Register vanilla Item registry into Registry sync v2 system
  • Set item translation key from identifier when registering it
  • [NEW] Fix item models not being associated with the right item after registry was remapped
  • [NEW] For 1.7.10, provide a transitive access widener for the method getFromId, allowing devs to set texture location more easily.

@thecatcore
Initial work on registry-sync-v2
6ade139
@thecatcore
More progress on registry api v2
f482232 
- differentiate "synced" Index-Key-Value registries from simple Key-Value registries
- start preparing registry remapping
@thecatcore
Initial work on item-api
c12dfb6
@thecatcore
spotless apply
2b57a72
@thecatcore
Start working on new registry remapper
d949960
@thecatcore
Merge branch 'feature/registry-sync-v2/api' into feature/registry-syn…
0a6871b 
…c-v2/item

# Conflicts:
#	legacy-fabric-registry-sync-api-v1/common.gradle
@thecatcore
Rename some classes
3002ffc
@thecatcore
Rename some classes
395e372
@thecatcore
Merge branch 'refs/heads/feature/registry-sync-v2/api' into feature/r…
e117bec 
…egistry-sync-v2/item
@thecatcore
Merge branch 'refs/heads/main' into feature/registry-sync-v2/api
188ea3d
@thecatcore
Merge branch 'refs/heads/feature/registry-sync-v2/api' into feature/r…
09146c1 
…egistry-sync-v2/item
@thecatcore
Move registry related test mods to per version global test mods
3c6e7ee
@thecatcore
Update loom and gradle
dec3757
@thecatcore
Port remapping system to v2 and port to every supported version
6f5bf3b
@thecatcore
Ensure backward compatibility with registry-sync-api-v1
b533add
@thecatcore
Merge branch 'refs/heads/feature/registry-sync-v2/api' into feature/r…
9998e02 
…egistry-sync-v2/item
@thecatcore
Item registry is fully ported already
f314ddd
@thecatcore
Make it easier to set item texture in 1.7.10
7d4714c
@thecatcore
Fix item models being wrong after registry is remapped for 1.8+
7649656
@thecatcore
Disable Block testmods as Block registry is not ported yet
cbd3b5a
@thecatcore
Fix a few possible crashes when using registries
648e610
@thecatcore
Add more useful methods to RegistryHelper
b6cbf78
@thecatcore
Merge branch 'refs/heads/feature/registry-sync-v2/api' into feature/r…
b9d5671 
…egistry-sync-v2/item
@thecatcore
Fix style
2bd406d
@thecatcore
Fix Item registry being registered before vanilla items initialisation
49679c5
@thecatcore
Remove block related fixes from item modules
2226ba6
@thecatcore
Make vanilla registries first assignable id 1 instead of 0
b2266b7
@thecatcore
Some improvements and bug fixes.
f47b8e2
@thecatcore
Create a default implementation of IdsHolder and SyncedRegistrableReg…
2ac36af 
…istry.
@thecatcore
Start working on wrapper for non-standard registry forms
5cb1492
@thecatcore thecatcore mentioned this pull request May 8, 2024
Draft
@thecatcore thecatcore mentioned this pull request May 8, 2024
Draft
@thecatcore thecatcore self-assigned this May 9, 2024
@thecatcore thecatcore added enhancement New feature or request help wanted Extra attention is needed new module New module bikeshed yes draft and removed help wanted Extra attention is needed labels May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thecatcore thecatcore

Labels
bikeshed yes draft enhancement New feature or request new module New module
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@thecatcore