Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update style.scss - Extend page width to 1280px #60

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

grenwi
Copy link
Member

@grenwi grenwi commented Feb 19, 2024

Changes for page width to allow for wider main section. Yet, untested. Please test in page render workflow and merge, of working.

@FlxVctr
Copy link
Member

FlxVctr commented Mar 18, 2024

Tested. Fixed width does not work on mobile/tablets (makes text unreadable).

Furthermore, in general UX and layout terms, narrower columns make text more readable. General rule of thumb is 12-20 words/100 chars per line. Why the change?

Edit: recommendations seem to be even shorter by now with 75 chars per line (https://baymard.com/blog/line-length-readability)

@FlxVctr
Copy link
Member

FlxVctr commented Mar 26, 2024

If we want to increase the width anyway, I just tested succesfully increasing the width of the wrapper to 1000 and the section element to 700 in the browser inspector (or other values, but needs some tweaking and testing so that everything works out in the end). This preserves the responsiveness of the design on mobile.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants