Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tag name processors with path #362

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mcwonka
Copy link

@mcwonka mcwonka commented Mar 8, 2017

I added a path param resulting in the new signature for tagNameProcessors(name, path)

We needed this to process node names based on their actual path, e.g.

const options = {
      trim: true,
      explicitArray: false,
      ignoreAttrs: false,
      tagNameProcessors: [function (childName, pathArray) {
        pathArray.push(childName);
        const pathWithChildInDotNotation = pathArray.join('.');
        return pathWithChildInDotNotation;
      }],
    };

I am looking forward to your comments!
Matthias

@coveralls
Copy link

coveralls commented Mar 8, 2017

Coverage Status

Coverage decreased (-3.4%) to 94.195% when pulling 0725ae0 on mcwonka:feature/tagNameProcessors-with-path into b5e351a on Leonidas-from-XIV:master.

@coveralls
Copy link

coveralls commented Mar 9, 2017

Coverage Status

Coverage decreased (-3.4%) to 94.195% when pulling 7dde069 on mcwonka:feature/tagNameProcessors-with-path into b5e351a on Leonidas-from-XIV:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants