fix(gptchangelog): attribute contributors inline per bullet instead of trailing list - #513
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe action now gathers commit SHA, short hash, and subject data from a single ChangesGPT changelog commit attribution
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
🔍 Lint Analysis
|
🔍 PR Validation Summary✅ PR Mergeable — no blocking failures
|
🛡️ CodeQL Analysis ResultsLanguages analyzed: ✅ No security issues found. 🔍 View full scan logs | 🛡️ Security tab |
There was a problem hiding this comment.
Warning
CodeRabbit couldn't request changes on this pull request because it doesn't have sufficient GitHub permissions.
Please grant CodeRabbit Pull requests: Read and write permission and re-run the review.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/changelog/gptchangelog/action.yml`:
- Around line 282-295: The commit annotation loop in the changelog action is
doing an extra `git log -1` per SHA even though the subject can be captured when
`SHAS` is first collected. Update the initial SHA-gathering logic and
`COMMITS_ANNOTATED` building in `action.yml` so each record includes full SHA,
short hash, and subject from one local `git log` pass, then reuse that subject
inside the loop while keeping the `gh api` login lookup keyed by the full SHA.
This removes the redundant local subprocess per commit and preserves the
existing author-handle annotation behavior.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 0af9daa4-c2a8-4a65-ba55-75c5bed3bb65
📒 Files selected for processing (1)
src/changelog/gptchangelog/action.yml
…xtra subprocesses
GitHub Actions Shared Workflows
Description
Previously the changelog ended with a generic
Contributors: @a, @blist — the same information GitHub already shows on the release page, adding no value.This PR changes the attribution model so each bullet point includes the
@handleof the author inline:Before:
After:
Implementation:
git log --oneline+ separate SHA loop for contributors) with a single annotated pass: for each commit SHA, fetch the subject line and the GitHub author login, buildingCOMMITS_ANNOTATEDas"short-hash subject [@author]"lines@handle(s)in parentheses at the end of each bullet; list all unique handles when a bullet groups multiple commitsTEMP_COMMITStemp file and theUSERNAMES_FILEtemp file (no longer needed)Type of Change
feat: New workflow or new input/output/step in an existing workflowfix: Bug fix in a workflow (incorrect behavior, broken step, wrong condition)perf: Performance improvement (e.g. caching, parallelism, reduced steps)refactor: Internal restructuring with no behavior changedocs: Documentation only (README, docs/, inline comments)ci: Changes to self-CI (workflows under.github/workflows/that run on this repo)chore: Dependency bumps, config updates, maintenancetest: Adding or updating testsBREAKING CHANGE: Callers must update their configuration after this PRBreaking Changes
None. The changelog content format changes (richer attribution per item) but no inputs, outputs, or caller contracts change.
Testing
git log -1 --format='%h %s'+ GitHub API login →"abc1234 fix(x): desc [@author]"Summary by CodeRabbit