Skip to content

feat(release): develop to main - #638

Merged
fredcamaral merged 11 commits into
mainfrom
develop
Aug 1, 2026
Merged

feat(release): develop to main#638
fredcamaral merged 11 commits into
mainfrom
develop

Conversation

@fredcamaral

Copy link
Copy Markdown
Member

Description

Promotes the current develop branch to main. This release adds optional per-job runner overrides across shared workflows, registers br-consignado-gw on Benedita, adds streaming-hub to the deployment matrix, and removes obsolete testing applications.

The release backmerge preserves the latest main cleanup while retaining all changes already accepted into develop.

Type of Change

  • feat: New workflow or new input/output/step in an existing workflow
  • fix: Bug fix in a workflow (incorrect behavior, broken step, wrong condition)
  • perf: Performance improvement (e.g. caching, parallelism, reduced steps)
  • refactor: Internal restructuring with no behavior change
  • docs: Documentation only (README, docs/, inline comments)
  • ci: Changes to self-CI (workflows under .github/workflows/ that run on this repo)
  • chore: Dependency bumps, config updates, maintenance
  • test: Adding or updating tests
  • BREAKING CHANGE: Callers must update their configuration after this PR

Breaking Changes

None.

Testing

  • YAML syntax validated locally
  • Triggered a real workflow run on a caller repository using @this-branch or the beta tag
  • Verified all existing inputs still work with default values
  • Confirmed no secrets or tokens are printed in logs
  • Checked that unrelated workflows are not affected

Caller repo / workflow run: Changes were validated in their original pull requests before being merged into develop.

Related Issues

None.

lerian-studio and others added 10 commits July 29, 2026 18:51
Adds `severino-testing-final` to `apps.registry` and to
`clusters.anacleto.apps` and `clusters.benedita.apps` (the repo's own lint requires an app in a cluster
list to also be in the registry).

Which environments actually receive updates is NOT decided here — this file
has no environment dimension. It is decided by whether the app's
values.yaml exists in the gitops repo, which the same automation created
only for the environments the requester selected. Environments without one
are logged as a WARNING by gitops-update.yml and skipped.

Provisioned-By: Severino app-provisioning automation
Provisioning-Request: 41ab349b-4565-43f0-9793-041a799f17ad
Provisioning-App: severino-testing-final
Provisioning-Requester: admin
Provisioning-Team: devops-team
Removes `severino-testing-final` from `apps.registry`, from every cluster list it
appeared under, and from any `app_helmfile_env` override — the app was torn
down, so leaving it registered would keep gitops-update attempting it on
every release and logging "values file not found" indefinitely.

Provisioned-By: Severino app-provisioning automation
Provisioning-Request: 41ab349b-4565-43f0-9793-041a799f17ad
Provisioning-App: severino-testing-final
Provisioning-Requester: admin
Provisioning-Team: devops-team
Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
…s-release forwarding

Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
# Conflicts:
#	config/deployment-matrix.yml
@fredcamaral
fredcamaral requested a review from a team as a code owner August 1, 2026 21:24
@coderabbitai

coderabbitai Bot commented Aug 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 249013ca-2715-47be-82da-96ab9119ec9d

📥 Commits

Reviewing files that changed from the base of the PR and between 390fafa and 8bce322.

📒 Files selected for processing (1)
  • .github/workflows/go-release.yml

Summary by CodeRabbit

  • New Features

    • Added optional runner overrides for build, test, lint, coverage, security scanning, validation, and release jobs.
    • Added the br-consignado-gw application to deployment configurations for the Anacleto and Benedita clusters.
  • Documentation

    • Documented the new runner configuration options and fallback behavior across workflow guides.

Walkthrough

The workflows add job-specific runner overrides with fallback resolution and forward these inputs across reusable workflow calls. Documentation describes the new inputs. The deployment matrix registers br-consignado-gw for the benedita cluster.

Changes

Job-specific workflow runners

Layer / File(s) Summary
Reusable workflow runner resolution
.github/workflows/build.yml, .github/workflows/go-pr-analysis.yml, .github/workflows/pr-security-scan.yml, .github/workflows/pr-validation.yml, .github/workflows/release.yml, docs/*
Reusable workflows accept job-specific runner inputs. Jobs prefer the specific input, then vars.GENERAL_RUNNERS, then runner_type.
Caller forwarding and gate runners
.github/workflows/go-pr-validation.yml, .github/workflows/go-release.yml, .github/workflows/js-release.yml
Validation and release workflows forward runner overrides to reusable workflows. Gate jobs use the shared override fallback order.

Deployment matrix registration

Layer / File(s) Summary
Application and cluster registration
config/deployment-matrix.yml
Registers br-consignado-gw in the application registry and for the benedita cluster.

Estimated code review effort: 3 (Moderate) | ~25 minutes

Possibly related PRs

Suggested labels: workflow, documentation, deployment-matrix, size/S

Suggested reviewers: bedatty, ferr3ira-gabriel, gauchito91, guimoreirar, jeffersonrodrigues92

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states that the pull request promotes the develop branch to main.
Description check ✅ Passed The description follows the template and covers scope, change type, breaking changes, testing, and related issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Warning

CodeRabbit couldn't request changes on this pull request because it doesn't have sufficient GitHub permissions.

Please grant CodeRabbit Pull requests: Read and write permission and re-run the review.

👉 Steps to fix this

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/go-release.yml:
- Line 445: Update the extra_build invocation in the release workflow to forward
inputs.build_runner_type using the same build_runner_type mapping already
present in the primary build call, ensuring both build calls honor the caller’s
runner selection override.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: ASSERTIVE

Plan: Pro

Run ID: efdf9d34-3949-417a-bbc8-2bcdab8b6a54

📥 Commits

Reviewing files that changed from the base of the PR and between 80428cc and 390fafa.

📒 Files selected for processing (17)
  • .github/workflows/build.yml
  • .github/workflows/go-pr-analysis.yml
  • .github/workflows/go-pr-validation.yml
  • .github/workflows/go-release.yml
  • .github/workflows/js-release.yml
  • .github/workflows/pr-security-scan.yml
  • .github/workflows/pr-validation.yml
  • .github/workflows/release.yml
  • config/deployment-matrix.yml
  • docs/build-workflow.md
  • docs/go-pr-analysis-workflow.md
  • docs/go-pr-validation.md
  • docs/go-release-workflow.md
  • docs/js-release.md
  • docs/pr-security-scan-workflow.md
  • docs/pr-validation.md
  • docs/release-workflow.md

release_version: ${{ github.ref_type == 'branch' && needs.release.outputs.new_release_version || '' }}
checkout_ref: ${{ github.ref_type == 'branch' && needs.release.outputs.new_release_git_tag || '' }}
runner_type: ${{ inputs.runner_type }}
build_runner_type: ${{ inputs.build_runner_type }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Forward build_runner_type to every build call.

Line 445 forwards the override to the primary build call. The extra_build job also calls .github/workflows/build.yml but does not pass this input. Callers that set build_runner_type therefore get inconsistent runner selection, and extra builds fall back to vars.GENERAL_RUNNERS or runner_type.

Add the same mapping to the extra_build call.

Proposed fix
       runner_type: ${{ inputs.runner_type }}
+      build_runner_type: ${{ inputs.build_runner_type }}
       enable_dockerhub: ${{ (matrix.group.enable_dockerhub == null && inputs.enable_dockerhub == true) || matrix.group.enable_dockerhub == true }}
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In @.github/workflows/go-release.yml at line 445, Update the extra_build
invocation in the release workflow to forward inputs.build_runner_type using the
same build_runner_type mapping already present in the primary build call,
ensuring both build calls honor the caller’s runner selection override.

Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
@lerian-studio lerian-studio added size/S PR changes 50–199 lines documentation Improvements or additions to documentation workflow Changes to one or more reusable workflow files security Changes to security workflows or vulnerability reporting policy golang Changes to Go-related workflows validate Changes to PR validation composite actions (src/validate/) deployment-matrix Changes to the canonical deployment matrix (config/deployment-matrix.yml) labels Aug 1, 2026
@lerian-studio

Copy link
Copy Markdown
Contributor

🔍 PR Validation Summary

✅ PR Mergeable — no blocking failures

Check Status Blocking
Source Branch ✅ success yes
PR Title ✅ success yes
PR Description ✅ success yes
PR Size ✅ success no
Auto Labels ✅ success no
PR Metadata ✅ success no

🔍 View workflow run

@lerian-studio

Copy link
Copy Markdown
Contributor

🔍 Lint Analysis

Check Files Scanned Status
YAML Lint 9 file(s) ✅ success
Action Lint 8 file(s) ✅ success
Pinned Actions 8 file(s) ✅ success
Markdown Link Check 8 file(s) ✅ success
Spelling Check 17 file(s) ✅ success
Shell Check 8 file(s) ✅ success
README Check 8 file(s) ✅ success
Composite Schema no changes ⏭️ skipped
Deployment Matrix 1 file(s) ✅ success

🔍 View full scan logs

@lerian-studio

Copy link
Copy Markdown
Contributor

🛡️ CodeQL Analysis Results

Languages analyzed: actions

Found 1 issue(s): 1 Medium

Severity Rule File Message
🟡 Medium actions/untrusted-checkout/medium .github/workflows/build.yml:304 Potential unsafe checkout of untrusted pull request on non-privileged workflow.

🔍 View full scan logs | 🛡️ Security tab

@fredcamaral
fredcamaral merged commit 5e560eb into main Aug 1, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deployment-matrix Changes to the canonical deployment matrix (config/deployment-matrix.yml) documentation Improvements or additions to documentation golang Changes to Go-related workflows security Changes to security workflows or vulnerability reporting policy size/S PR changes 50–199 lines validate Changes to PR validation composite actions (src/validate/) workflow Changes to one or more reusable workflow files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants