feat(release): develop to main - #638
Conversation
…-hub app to deployment matrix
Adds `severino-testing-final` to `apps.registry` and to `clusters.anacleto.apps` and `clusters.benedita.apps` (the repo's own lint requires an app in a cluster list to also be in the registry). Which environments actually receive updates is NOT decided here — this file has no environment dimension. It is decided by whether the app's values.yaml exists in the gitops repo, which the same automation created only for the environments the requester selected. Environments without one are logged as a WARNING by gitops-update.yml and skipped. Provisioned-By: Severino app-provisioning automation Provisioning-Request: 41ab349b-4565-43f0-9793-041a799f17ad Provisioning-App: severino-testing-final Provisioning-Requester: admin Provisioning-Team: devops-team
Removes `severino-testing-final` from `apps.registry`, from every cluster list it appeared under, and from any `app_helmfile_env` override — the app was torn down, so leaving it registered would keep gitops-update attempting it on every release and logging "values file not found" indefinitely. Provisioned-By: Severino app-provisioning automation Provisioning-Request: 41ab349b-4565-43f0-9793-041a799f17ad Provisioning-App: severino-testing-final Provisioning-Requester: admin Provisioning-Team: devops-team
Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
…s-release forwarding Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
# Conflicts: # config/deployment-matrix.yml
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
Summary by CodeRabbit
WalkthroughThe workflows add job-specific runner overrides with fallback resolution and forward these inputs across reusable workflow calls. Documentation describes the new inputs. The deployment matrix registers ChangesJob-specific workflow runners
Deployment matrix registration
Estimated code review effort: 3 (Moderate) | ~25 minutes Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Warning
CodeRabbit couldn't request changes on this pull request because it doesn't have sufficient GitHub permissions.
Please grant CodeRabbit Pull requests: Read and write permission and re-run the review.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/go-release.yml:
- Line 445: Update the extra_build invocation in the release workflow to forward
inputs.build_runner_type using the same build_runner_type mapping already
present in the primary build call, ensuring both build calls honor the caller’s
runner selection override.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yml
Review profile: ASSERTIVE
Plan: Pro
Run ID: efdf9d34-3949-417a-bbc8-2bcdab8b6a54
📒 Files selected for processing (17)
.github/workflows/build.yml.github/workflows/go-pr-analysis.yml.github/workflows/go-pr-validation.yml.github/workflows/go-release.yml.github/workflows/js-release.yml.github/workflows/pr-security-scan.yml.github/workflows/pr-validation.yml.github/workflows/release.ymlconfig/deployment-matrix.ymldocs/build-workflow.mddocs/go-pr-analysis-workflow.mddocs/go-pr-validation.mddocs/go-release-workflow.mddocs/js-release.mddocs/pr-security-scan-workflow.mddocs/pr-validation.mddocs/release-workflow.md
| release_version: ${{ github.ref_type == 'branch' && needs.release.outputs.new_release_version || '' }} | ||
| checkout_ref: ${{ github.ref_type == 'branch' && needs.release.outputs.new_release_git_tag || '' }} | ||
| runner_type: ${{ inputs.runner_type }} | ||
| build_runner_type: ${{ inputs.build_runner_type }} |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟠 Major | ⚡ Quick win
Forward build_runner_type to every build call.
Line 445 forwards the override to the primary build call. The extra_build job also calls .github/workflows/build.yml but does not pass this input. Callers that set build_runner_type therefore get inconsistent runner selection, and extra builds fall back to vars.GENERAL_RUNNERS or runner_type.
Add the same mapping to the extra_build call.
Proposed fix
runner_type: ${{ inputs.runner_type }}
+ build_runner_type: ${{ inputs.build_runner_type }}
enable_dockerhub: ${{ (matrix.group.enable_dockerhub == null && inputs.enable_dockerhub == true) || matrix.group.enable_dockerhub == true }}🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In @.github/workflows/go-release.yml at line 445, Update the extra_build
invocation in the release workflow to forward inputs.build_runner_type using the
same build_runner_type mapping already present in the primary build call,
ensuring both build calls honor the caller’s runner selection override.
Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
🔍 PR Validation Summary✅ PR Mergeable — no blocking failures
|
🔍 Lint Analysis
|
🛡️ CodeQL Analysis ResultsLanguages analyzed: Found 1 issue(s): 1 Medium
🔍 View full scan logs | 🛡️ Security tab |
Description
Promotes the current
developbranch tomain. This release adds optional per-job runner overrides across shared workflows, registersbr-consignado-gwon Benedita, addsstreaming-hubto the deployment matrix, and removes obsolete testing applications.The release backmerge preserves the latest
maincleanup while retaining all changes already accepted intodevelop.Type of Change
feat: New workflow or new input/output/step in an existing workflowfix: Bug fix in a workflow (incorrect behavior, broken step, wrong condition)perf: Performance improvement (e.g. caching, parallelism, reduced steps)refactor: Internal restructuring with no behavior changedocs: Documentation only (README, docs/, inline comments)ci: Changes to self-CI (workflows under.github/workflows/that run on this repo)chore: Dependency bumps, config updates, maintenancetest: Adding or updating testsBREAKING CHANGE: Callers must update their configuration after this PRBreaking Changes
None.
Testing
@this-branchor the beta tagCaller repo / workflow run: Changes were validated in their original pull requests before being merged into
develop.Related Issues
None.