Skip to content

fix(helm-upgrade-doc): use generic SLACK_CHANNEL secret for notifications #643

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guimoreirar merged 1 commit into from
Aug 4, 2026
Merged

fix(helm-upgrade-doc): use generic SLACK_CHANNEL secret for notifications #643

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions .github/workflows/helm-upgrade-doc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,14 @@ name: "Helm Upgrade Doc"
# upgrade-doc:
# uses: LerianStudio/github-actions-shared-workflows/.github/workflows/helm-upgrade-doc.yml@v1
# secrets: inherit
#
# Slack channel: the notification channel is a GENERIC `SLACK_CHANNEL` secret, so
# switching channels never requires editing this shared workflow. With
# `secrets: inherit` it uses the caller's `SLACK_CHANNEL`. To point at a different
# channel, map any channel secret to it in the CALLER (instead of inherit):
# secrets:
# SLACK_CHANNEL: ${{ secrets.SLACK_CHANNEL_OPS }} # or any channel secret
# # ...plus the other secrets this workflow requires...
Comment thread
guimoreirar marked this conversation as resolved.

on:
workflow_call:
Expand Down Expand Up @@ -58,7 +66,7 @@ on:
required: false
SLACK_BOT_TOKEN_HELM:
required: false
SLACK_CHANNEL_OPS:
SLACK_CHANNEL:
required: false
SLACK_GROUP_TECH_SUPPORT:
required: false
Expand Down Expand Up @@ -92,7 +100,7 @@ jobs:
anthropic-api-key: ${{ secrets.ANTHROPIC_API_KEY }}
openrouter-api-key: ${{ secrets.OPENROUTER_API_KEY }}
slack-bot-token: ${{ secrets.SLACK_BOT_TOKEN_HELM }}
slack-channel: ${{ secrets.SLACK_CHANNEL_OPS }}
slack-channel: ${{ secrets.SLACK_CHANNEL }}
slack-group-ops: ${{ secrets.SLACK_GROUP_TECH_SUPPORT }}
charts-root: ${{ inputs.charts_root }}
docs-subdir: ${{ inputs.docs_subdir }}
Expand Down
Loading