fix(security): align codeql init/analyze pins with autobuild - #655
Merged
Conversation
Co-authored-by: Codesmith <codesmith-bot@users.noreply.github.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
Summary by CodeRabbit
WalkthroughThe pull request updates the pinned commits for the CodeQL initialization and analysis actions. Existing version labels and inputs remain unchanged. ChangesCodeQL action pins
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Contributor
🔍 Lint Analysis
|
Contributor
🔍 PR Validation Summary✅ PR Mergeable — no blocking failures
|
Contributor
🛡️ CodeQL Analysis ResultsLanguages analyzed: ✅ No security issues found. 🔍 View full scan logs | 🛡️ Security tab |
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Every
codeql_scanjob inpr-security-scan.yml(and thusgo-pr-validation.yml) currently fails on Go-changing PRs with:Root cause: the
codeql-init/codeql-analyzecomposites pingithub/codeql-actionatc10b8064(v4.35.1), while theAutobuildstep insidepr-security-scan.ymlwas bumped by Dependabot to54f647b7(v4.36.3, tag v1.46.x) ande4fba868(v4.37.3, develop / v1.48+).codeql-actionrequires init/autobuild/analyze to run the exact same version, so the mix hard-fails before the build starts. Dependabot cannot see the composites (src/**/action.ymlis outside thegithub-actionsecosystem scan, as noted in.github/dependabot.yml), which is how the pins drifted.This PR aligns both composites with the pin already used by
Autobuildandupload-sarifon develop:Note for consumers: because the composites resolve via the floating
@v1tag, callers pinned to tags whoseAutobuildstep is on a different codeql-action version (e.g. v1.46.x → v4.36.3) will still mismatch after this ships; they need to bump to a tag whose autobuild pin ise4fba868(v1.48.0+). Longer term, consider havingpr-security-scan.ymlconsume autobuild through a composite too, so all four codeql-action steps bump atomically.Type of Change
fix: Bug fix in a workflow (incorrect behavior, broken step, wrong condition)Breaking Changes
None.
Testing
@this-branchor the beta tagCaller repo / workflow run: Failure reproduced on https://github.com/LerianStudio/plugin-br-bank-transfer/actions/runs/31132478400 (
validate / Security (pipeline) / codeql_scan); the pins are only consumed via@v1, so a pre-merge caller run cannot exercise this change directly.Related Issues
Closes #