feat(midaz): add CRM/Fees/Tracer env vars and update tracer image#1695
Closed
gandalf-at-lerian wants to merge 1 commit into
Closed
feat(midaz): add CRM/Fees/Tracer env vars and update tracer image#1695gandalf-at-lerian wants to merge 1 commit into
gandalf-at-lerian wants to merge 1 commit into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (7)
📝 WalkthroughWalkthroughThe Midaz ledger chart adds CRM, Fees, crypto, and Tracer configuration. The Tracer chart adds Reservation Reaper and Rule Sync settings. Both chart versions are incremented. ChangesMidaz ledger configuration
Tracer configuration
Possibly related PRs
✨ Finishing Touches✨ Simplify code
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Ygohr
changed the title
Ygohr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by: Ygohr
Contexto
PR LerianStudio/midaz#2159 consolidou tracer, fees e CRM no binário unificado do ledger (midaz v4 monorepo); #2239 corrigiu o Dockerfile. O chart do ledger renderiza apenas chaves explícitas do configmap/secrets (não faz
rangegenérico), então as novas env vars precisam de suporte explícito no template para que os overrides do gitops tenham efeito.midaz chart (version 8.6.0 → 8.6.1)
templates/ledger/configmap.yaml: renderizaMONGO_CRM_*,KMS_VENDOR,MONGO_FEES_*e o seam do Tracer (TRACER_BASE_URL,TRACER_TRANSPORT,TRACER_TLS_MODE).templates/ledger/secrets.yaml: renderizaLCRYPTO_HASH_SECRET_KEY,LCRYPTO_ENCRYPT_SECRET_KEY,MONGO_CRM_PASSWORD,MONGO_FEES_PASSWORD— todas com guards{{- if }}, só emitidas quando setadas (deployments existentes não afetados).values.yaml(seçãoledger): defaults seguros (strings vazias) para todas as novas chaves de configmap e secrets.tracer chart (version 2.1.0 → 2.1.1)
templates/configmap.yaml+values.yaml: adicionadasRESERVATION_REAPER_ENABLED,RESERVATION_REAPER_INTERVAL_SECONDS,RULE_SYNC_POLL_INTERVAL_SECONDScom defaults seguros.Verificação
helm lintOK em ambos os charts (warnings de RABBITMQ pré-existentes, não relacionados).helm templateconfirma que todas as novas chaves renderizam corretamente.