Conversation
Bump gofiber/fiber v2.52.13 -> v3.4.0 (v2 dropped) and cut the /v2 module major. fiber.Ctx is now an interface passed by value: all *fiber.Ctx signatures across middleware/ and tracing/ drop the pointer. c.UserContext()/SetUserContext() -> c.Context()/SetContext(); app.Add now takes []string. No behavior change intended. BREAKING CHANGE: module path is now github.com/LerianStudio/lib-observability/v2 and exported HTTP helpers take fiber.Ctx by value; consumers must be on Fiber v3. X-Lerian-Ref: 0x1
Fiber v3 pulls golang.org/x/crypto via acme/autocert; the openpgp unmaintained advisory has no fixed version and the package is not imported. Matches the suppression already present on other services' develop. X-Lerian-Ref: 0x1
feat(core)!: migrate to Fiber v3, cut /v2 major
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe project adopts the ChangesModule and HTTP API migration
Sequence Diagram(s)sequenceDiagram
participant FiberCtx
participant WithTelemetry
participant ExtractHTTPContext
participant MetricsFactory
FiberCtx->>WithTelemetry: provide fiber.Ctx
WithTelemetry->>ExtractHTTPContext: extract trace context from c.Context()
ExtractHTTPContext-->>WithTelemetry: propagated context
WithTelemetry->>FiberCtx: store telemetry state with SetContext
WithTelemetry->>MetricsFactory: record request duration from c.Context()
Possibly related PRs
✨ Finishing Touches✨ Simplify code
Comment |
🔒 Security Scan Results —
|
| Stage | Status | Blocking? |
|---|---|---|
| Filesystem Scan | ✅ Clean | — |
| Docker Image Scan | ➖ Skipped | — |
| Docker Hub Health Score | ➖ Skipped | — |
| Pre-release Version Check | ✅ Clean | — |
Trivy
Filesystem Scan
✅ No vulnerabilities or secrets found.
Pre-release Version Check
✅ No unstable version pins found.
🔍 PR Validation Summary✅ PR Mergeable — no blocking failures
|
📊 Unit Test Coverage Report:
|
| Metric | Value |
|---|---|
| Overall Coverage | 85.7% ✅ PASS |
| Threshold | 80% |
Coverage by Package
| Package | Coverage |
|---|---|
github.com/LerianStudio/lib-observability/v2/assert |
97.9% |
github.com/LerianStudio/lib-observability/v2/constants |
83.3% |
github.com/LerianStudio/lib-observability/v2/log |
94.9% |
github.com/LerianStudio/lib-observability/v2/metrics |
91.4% |
github.com/LerianStudio/lib-observability/v2/middleware |
76.9% |
github.com/LerianStudio/lib-observability/v2/redaction |
95.8% |
github.com/LerianStudio/lib-observability/v2/runtime |
80.4% |
github.com/LerianStudio/lib-observability/v2/tracing |
84.8% |
github.com/LerianStudio/lib-observability/v2/zap |
96.0% |
github.com/LerianStudio/lib-observability/v2 |
91.5% |
Generated by Go PR Analysis workflow
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.trivyignore:
- Line 5: Update the GO-2026-5932 entry in .trivyignore by either renewing its
expiration with a responsible owner or tracking issue, or removing the ignore if
the advisory is no longer reachable.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 13b6190b-d326-4fcf-8690-b3fd3a970a82
⛔ Files ignored due to path filters (1)
go.sumis excluded by!**/*.sum
📒 Files selected for processing (42)
.trivyignoreassert/assert.goassert/assert_extended_test.goassert/assert_test.gocontext_tracking_test.gogo.modlog/go_logger.gometrics/metrics.gometrics/metrics_test.gomiddleware/context_span.gomiddleware/context_span_test.gomiddleware/helpers.gomiddleware/helpers_test.gomiddleware/logging.gomiddleware/logging_obfuscation.gomiddleware/logging_test.gomiddleware/metrics.gomiddleware/request_attrs.gomiddleware/telemetry.gomiddleware/telemetry_metrics_test.gomiddleware/telemetry_route_test.gomiddleware/telemetry_test.gomiddleware/tenant.gomiddleware/tenant_test.goobservability.goruntime/goroutine.goruntime/helpers_test.goruntime/log_mode_link_test.goruntime/metrics.goruntime/metrics_test.goruntime/recover.goruntime/tracing.gosystem.gosystem_test.gotracing/obfuscation.gotracing/obfuscation_test.gotracing/otel.gotracing/otel_test.gotracing/processor.gotracing/v2_test.gozap/zap.gozap/zap_test.go
Resolves CVE-2026-56852 (infinite loop on invalid input) flagged as a blocking finding by the Trivy filesystem scan. x/text is an indirect dependency (Fiber v3, grpc-gateway, fasthttp, x/crypto, x/net). X-Lerian-Ref: 0x1
fix(deps): bump golang.org/x/text to v0.39.0 (CVE-2026-56852)
Lib Observability
Description
Release of the v2 major to
main(stable). Migrates the library to Fiber v3 and cuts the/v2module path (github.com/LerianStudio/lib-observability/v2).Affected packages:
middleware,tracing,runtime,zap,assert,metrics,log, plus module metadata (go.mod/go.sum).Type of Change
BREAKING CHANGE: Consumers must update their integrationfeat: New feature or capabilitybuild: Build system, Go module dependenciesBreaking Changes
/v2— import path is nowgithub.com/LerianStudio/lib-observability/v2/.... Downstream services must update every import and rungo mod tidy.gofiber/fiber/v3; consumers still on Fiber v2 must migrate.Testing
make testpassesmake lintpassesTest evidence / Actions run: CI on
develop.Architectural Checklist
panic()in production paths — usesasserthelpers or wrapped errorslib-commonsimport (circular — see CLAUDE.md)Related Issues
Closes #