Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adding hangul syllables #93

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

typemytype
Copy link
Collaborator

todo:

  • Consult native Korean designers
  • Fix conflict with the "Hangul Jamo" range: fe: ko:ya appears in both ranges
  • remove the experimental flag

@typemytype
Copy link
Collaborator Author

A generated list of Hangul Syllables, no corrections on conflicts
HangulSyllables.txt

@NoheulLee
Copy link

@typemytype
hmmm.. for Hangul, those are different and we use both.
eg.

  • Ko: yaCompa-ko (ㅑ) (Hangul Compatibility Jamo, "Ya") / U_+3151 => Vowel (ㅑ)
  • Ko: ya (야) (Hangul Syllables, "Ya") / U+C57C => Consonant + Vowel (o + ㅑ)

스크린샷 2020-07-22 오후 7 44 06

@typemytype
Copy link
Collaborator Author

both have to be in a GNFUL list!

we can rename the prefix for the range Hangul Compatibility Jamo to koCompa if this makes it more clear what a designer needs to draw. The current implementation has ko as prefix for Hangul Compatibility Jamo.

koCompa:ya --> Hangul Compatibility Jamo, "Ya"
ko:ya --> Hangul Syllables , "Ya"

@lianghai
Copy link

lianghai commented Nov 7, 2020

Because Hangul Compatibility Jamo block (3130..318F) characters (despite the “LETTER” names) are encoding-level special cases of the Hangul Jamo (1100..11FF) characters, they should be named after the corresponding (unicodedata.normalize("NFKD", character)) characters in the latter block, with a disambiguating tag (such as the koCompa prefix).

For example, as U+1163 ᅣ HANGUL JUNGSEONG YA is currently named ko:yajungseong, and U+3151 ㅑ HANGUL LETTER YA has a compatibility decomposition of U+1163, the latter could be named koCompa:yajungseong or ko:yajungseongcomp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants