Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added code to run on Power systems #371

Closed
wants to merge 1 commit into from

Conversation

genisysram
Copy link

Hi
Here is my contribution to your code, its working good on powersystems.

Thanks for the code, its working good.

What do these changes do?

Added Architecture "ppc64le"

Are there changes in behavior for the user?

No

@vweevers
Copy link
Member

vweevers commented Jan 1, 2021

Thanks for the PR. My response is the same as browserify/node-util#53 (comment):

Nothing about this package (or any pure-JS package that doesn't touch the filesystem) can vary based on architecture, so testing in other architectures is not valuable.

On abstract-leveldown we can guarantee we'll never introduce dependencies with native addons, or touch the filesystem, because abstract-leveldown is an abstract interface that targets both node and browsers.

Testing against ppc64le would be valuable on native addons like https://github.com/Level/leveldown.

@vweevers vweevers closed this Jan 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants