Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARRISEOS-45892 limit conservative scan range (#410) #414

Commits on Aug 21, 2024

  1. ARRISEOS-45892 limit conservative scan range (#410)

    * ARRISEOS-45892 limit conservative scan range
    
    Turns out that conservative GC root scanning is
    scanning too deep into the stack & this results
    in GC being prevented (for more details see the
    ticket & upstream issue:
    WebPlatformForEmbedded#1363
    
    This workaround introduces 'stack guards' that prevent
    this in particular cases, that is - if there is gloop
    main loop routine in the stack (see RunLoopGLib), the
    GC root search will not go deeper that this frame. This
    is enough to make GC work when invoked synchronously,
    via VM::shrinkFootprintWhenIdle; therefore for the
    workaround to work, wpe plugin needs to call that
    (another part of the workaround is implemented in
    WebKitBrowser plugin)
    
    * ARRISEOS-45892 limit conservative scan range
    
    Small correction: immediate garbageCollectNow is
    still useful, since under heavy load shrinkFootprintWhenIdle
    might be executed quite late.
    tomasz-karczewski-red authored and amol-virnodkar-infosys committed Aug 21, 2024
    Configuration menu
    Copy the full SHA
    4f186d0 View commit details
    Browse the repository at this point in the history