Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't check for the existence of a 'normalized file' if the file exists #138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

don't check for the existence of a 'normalized file' if the file exists #138

wants to merge 1 commit into from

Conversation

rvanheest
Copy link

Checking the existence of the 'normalized file' is quite expensive and often not necessary. This PR moves the call to existsNormalized() to a later point such that is isn't required to run if not necessary.

@jscancella
Copy link
Contributor

@rvanheest I'm not sure the LoC actively maintains this anymore. I was the main author of this library and have forked it to continue maintaining it, check out https://github.com/jscancella/bagging

@rvanheest
Copy link
Author

rvanheest commented May 7, 2020

Hi @jscancella I'm aware of the inactivity of LoC on this library since you left. For this reason, we at @DANS-KNAW started a friendly fork for this library last year where we merged some of the available pull requests from last year. We deployed this version under our own groupId on Maven and have been using that fork ever since. Today I made the change in this PR on that fork and I thought I would contribute it to the main fork as well, as this change saves an O(n^2) magnitude of work in the validation process. I'll leave the PR open for LoC if they'd like to include it at some point. We'll continue on our own fork as long as LoC leaves this repository inactive.

@jscancella
Copy link
Contributor

@rvanheest I too forked the repo and continued developing it adding new features and much more documentation. Please give it a try and provide any feedback you have https://github.com/jscancella/bagging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants