wip, DNM: testing - #168
Closed
JohnVillalovos wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR appears to be a WIP change intended to force a Docker image build failure for testing within the repo’s Docker-based build pipeline.
Changes:
- Adds an unconditional failing command (
false) in the Dockerfile’s Apache/PHP customization build step.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| # Customize the http & php environment | ||
| RUN <<EORUN | ||
| set -xeu | ||
| false |
There was a problem hiding this comment.
The false command will cause this Docker build step (and therefore the entire image build) to fail every time. Remove it (or gate it behind a build arg / CI-only conditional) before merging so the Dockerfile remains buildable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.