Fix issue 169 - #184
Merged
Merged
Conversation
added 4 commits
March 13, 2026 17:42
Dockerfile: in charge of retrieving librebooking files and SHA setup.sh: librebooking customization
The last commit id matches the last 7 characters of `git describe --tags --long`
ikke-t
approved these changes
Mar 15, 2026
ikke-t
left a comment
ikke-t
left a comment
Collaborator
There was a problem hiding this comment.
Only the cosmetic change of regexp to comment. Looks good overall. Change it or not, I approve
added 3 commits
March 15, 2026 17:45
The length of the short commit id is not always 7 characters.
- Argument "--keep-git-dir" not recognized by podman build - Implement git clone inside the alpine/git image section - Implement "config/custom-version.txt" - Remove ".git" directory upstream version is saved
JohnVillalovos
approved these changes
Mar 15, 2026
JohnVillalovos
left a comment
JohnVillalovos
left a comment
Collaborator
There was a problem hiding this comment.
Thanks @colisee
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
gitis not needed in the imagesetup.shdoes not need to be in the imageconfig/custom-version.txtwith the output ofgit describe --tags --longClose #169