test: fix date/time dependent test failure (again)#1028
Merged
JohnVillalovos merged 1 commit intodevelopfrom Feb 16, 2026
Merged
test: fix date/time dependent test failure (again)#1028JohnVillalovos merged 1 commit intodevelopfrom
JohnVillalovos merged 1 commit intodevelopfrom
Conversation
Use Date::_SetNow() to set a fixed date/time for the test
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes date/time dependent test failures in two reservation test methods by replacing the use of TestBase::GetTestDate() with explicit Date::_SetNow() calls. The issue with TestBase::GetTestDate() is that it internally calls Date::Now(), making the tests non-deterministic and prone to failure at different times or in different timezones.
Changes:
- Replace
TestBase::GetTestDate()with fixed date mocking usingDate::_SetNow()in two test methods - Set a fixed "now" (January 15, 2026, 12:00 PM America/Chicago) before calculating test dates
- Makes tests fully deterministic and timezone-independent
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Date::_SetNow() to set a fixed date/time for the test