refactor(date-attribute): replace native date time input with flatpickr#1076
Merged
JohnVillalovos merged 1 commit intodevelopfrom Feb 24, 2026
Merged
refactor(date-attribute): replace native date time input with flatpickr#1076JohnVillalovos merged 1 commit intodevelopfrom
JohnVillalovos merged 1 commit intodevelopfrom
Conversation
Collaborator
JohnVillalovos
commented
Feb 23, 2026
JohnVillalovos
commented
- Add d-block class to label for better spacing
- Change input type to text to use flatpickr
- Remove hidden formatted input and explicit formatdate value
- Pass the attribute value as DefaultDate to DatePickerSetupControl (HasTimepicker remains true)
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the custom attribute datetime input UI to use the Flatpickr-backed DatePickerSetupControl instead of the native datetime-local input, improving layout and aiming for consistent date picking behavior across browsers.
Changes:
- Adds Bootstrap
d-blockto the attribute label for improved spacing. - Switches the datetime input from
datetime-localtotextto support Flatpickr. - Removes the hidden “formatted” input and instead passes the attribute value via
DefaultDateintoDatePickerSetupControl.
JohnVillalovos
force-pushed
the
jlvillal/flat1
branch
from
839c9d1 to
e7a4608
Compare
JohnVillalovos
force-pushed
the
jlvillal/flat1
branch
from
e7a4608 to
0cacdb0
Compare
JohnVillalovos
force-pushed
the
jlvillal/flat1
branch
from
0cacdb0 to
45d8bb7
Compare
- Add d-block class to label for better spacing - Change input type to text to use flatpickr - Remove hidden formatted input and explicit formatdate value - Pass the attribute value as DefaultDate to DatePickerSetupControl (HasTimepicker remains true)
JohnVillalovos
force-pushed
the
jlvillal/flat1
branch
from
45d8bb7 to
58d32bc
Compare
JohnVillalovos
commented
Feb 24, 2026
Collaborator
Author
JohnVillalovos
left a comment
JohnVillalovos
left a comment
There was a problem hiding this comment.
Thanks @labmecanicatec
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.