Skip to content

fix(config): Precise units for reservation reminders #1077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JohnVillalovos merged 1 commit into from
Feb 24, 2026
+7 −7
Merged

fix(config): Precise units for reservation reminders #1077

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions config/config.dist.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,10 +346,10 @@
# Enable reminder notifications for upcoming reservations (true/false)
'reminders.enabled' => false,

# Default reminder time before reservation start (in minutes)
# Default reminder time before reservation start (e.g., '15 minutes', '1 hours', '1 days')
'default.start.reminder' => '',

# Default reminder time before reservation end (in minutes)
# Default reminder time before reservation end (e.g., '15 minutes', '1 hours', '1 days')
'default.end.reminder' => '',
],

Expand Down
2 changes: 1 addition & 1 deletion docs/source/ADVANCED-CONFIGURATION.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ Reservation Behavior
Enable email reminders before reservations start/end.

**reservation.default.start.reminder**
Default reminder time before start (e.g., '15 minutes', '1 hour').
Default reminder time before start (e.g., '15 minutes', '1 hours', '1 days').
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The examples here use "1 hours" / "1 days", which reads like a grammatical mistake and may confuse users. Since the code only recognizes plural unit tokens (minutes/hours/days), consider using examples with values > 1 (e.g., '2 hours', '6 days') to stay both valid and grammatically natural.

Suggested change
Default reminder time before start (e.g., '15 minutes', '1 hours', '1 days').
Default reminder time before start (e.g., '15 minutes', '2 hours', '6 days').

Copilot uses AI. Check for mistakes.

**reservation.default.end.reminder**
Default reminder time before end.
Copy link

Copilot AI Feb 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The advanced configuration docs update the start reminder examples, but the end reminder entry still doesn’t mention that a unit is required or provide a valid example. This looks inconsistent with the PR’s stated goal (start/end reminders require units); please update reservation.default.end.reminder to include the same format guidance/examples.

Suggested change
Default reminder time before end.
Default reminder time before end; must include a number and time unit (e.g., '15 minutes', '1 hours', '1 days').

Copilot uses AI. Check for mistakes.
Expand Down
8 changes: 4 additions & 4 deletions lib/Config/ConfigKeys.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -808,17 +808,17 @@ class ConfigKeys
'key' => 'reservation.default.start.reminder',
'type' => 'string',
'default' => '',
'label' => 'Default Start Reminder (minutes)',
'description' => 'Default start reservation reminder. format is ## interval. for example, 10 minutes, 2 hours, 6 days.',
'label' => 'Default reminder time before reservation start (e.g., \'15 minutes\', \'1 hours\', \'1 days\')',
'description' => 'Default start reservation reminder. Format is an interval using only minutes, hours, or days',
'section' => 'reservation'
];
# previously RESERVATION_DEFAULT_END_REMINDER
public const RESERVATION_REMINDER_DEFAULT_END = [
'key' => 'reservation.default.end.reminder',
'type' => 'string',
'default' => '',
'label' => 'Default End Reminder (minutes)',
'description' => 'Default end reservation reminder. format is ## interval. for example, 10 minutes, 2 hours, 6 days.',
'label' => 'Default reminder time before reservation end (e.g., \'15 minutes\', \'1 hours\', \'1 days\')',
'description' => 'Default end reservation reminder. Format is an interval using only minutes, hours, or days (e.g., 1 days)',
'section' => 'reservation'
];

Expand Down