Skip to content

Comments

refactor(manage-reservations): replace native date time input with fl…#1081

Merged
JohnVillalovos merged 1 commit intodevelopfrom
jlvillal/flat1
Feb 25, 2026
Merged

refactor(manage-reservations): replace native date time input with fl…#1081
JohnVillalovos merged 1 commit intodevelopfrom
jlvillal/flat1

Conversation

@JohnVillalovos
Copy link
Collaborator

…atpickr

  • Update startDate/endDate element access in reservations.js to use getElementById and .value for filter query
  • Change startDate/endDate input type to text to use flatpickr
  • Remove hidden formatted inputs and update DatePickerSetupControl calls to pass DefaultDate

…atpickr

- Update startDate/endDate element access in reservations.js to use getElementById and .value for filter query
- Change startDate/endDate input type to text to use flatpickr
- Remove hidden formatted inputs and update DatePickerSetupControl calls to pass DefaultDate
Copilot AI review requested due to automatic review settings February 24, 2026 17:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Admin “Manage Reservations” date filters to use the Flatpickr-backed DatePickerSetupControl instead of native <input type="date">, and adjusts the client-side filtering code to read the new inputs correctly.

Changes:

  • Switch startDate/endDate inputs from type="date" (and hidden formatted fields) to type="text" driven by DatePickerSetupControl with DefaultDate.
  • Update reservations.js to read start/end dates from the new input elements via getElementById(...).value.
  • Move search-clear.js into the main JS include block (removing the duplicate include at the bottom).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
tpl/Admin/Reservations/manage_reservations.tpl Replaces native date inputs/hidden formatted fields with Flatpickr setup via DatePickerSetupControl, and adjusts script includes.
Web/scripts/admin/reservations.js Updates filter query construction to pull date values from the new input elements.

Copy link
Collaborator Author

@JohnVillalovos JohnVillalovos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @labmecanicatec

LGTM

@JohnVillalovos JohnVillalovos merged commit 22d7b7d into develop Feb 25, 2026
19 checks passed
@JohnVillalovos JohnVillalovos deleted the jlvillal/flat1 branch February 25, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants