refactor(manage-reservations): replace native date time input with fl…#1081
Merged
JohnVillalovos merged 1 commit intodevelopfrom Feb 25, 2026
Merged
refactor(manage-reservations): replace native date time input with fl…#1081JohnVillalovos merged 1 commit intodevelopfrom
JohnVillalovos merged 1 commit intodevelopfrom
Conversation
…atpickr - Update startDate/endDate element access in reservations.js to use getElementById and .value for filter query - Change startDate/endDate input type to text to use flatpickr - Remove hidden formatted inputs and update DatePickerSetupControl calls to pass DefaultDate
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Admin “Manage Reservations” date filters to use the Flatpickr-backed DatePickerSetupControl instead of native <input type="date">, and adjusts the client-side filtering code to read the new inputs correctly.
Changes:
- Switch
startDate/endDateinputs fromtype="date"(and hidden formatted fields) totype="text"driven byDatePickerSetupControlwithDefaultDate. - Update
reservations.jsto read start/end dates from the new input elements viagetElementById(...).value. - Move
search-clear.jsinto the main JS include block (removing the duplicate include at the bottom).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tpl/Admin/Reservations/manage_reservations.tpl | Replaces native date inputs/hidden formatted fields with Flatpickr setup via DatePickerSetupControl, and adjusts script includes. |
| Web/scripts/admin/reservations.js | Updates filter query construction to pull date values from the new input elements. |
JohnVillalovos
commented
Feb 25, 2026
Collaborator
Author
JohnVillalovos
left a comment
There was a problem hiding this comment.
Thanks @labmecanicatec
LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…atpickr