-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
alsa-utils: restore default card state handling #8662
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -26,20 +26,8 @@ post_configure_target() { | |
} | ||
|
||
post_makeinstall_target() { | ||
rm -rf ${INSTALL}/lib ${INSTALL}/var | ||
rm -rf ${INSTALL}/usr/share/alsa/speaker-test | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this wasnt doing anything |
||
rm -rf ${INSTALL}/usr/share/sounds | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do we want these WAV files?
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. They're used by There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It would be preferrable to include a single .wav sample (a reduced-in-size one if possible; doesn't need to be one from the original package) and then create symlinks that recreate the appearance of having the standard files, but avoiding the bloat of actually including them. It might sound daft, but that's the ethos of a minimalist distro :) |
||
rm -rf ${INSTALL}/usr/lib/systemd/system | ||
|
||
# remove default udev rule to restore mixer configs, we install our own. | ||
# so we avoid resetting our soundconfig | ||
rm -rf ${INSTALL}/usr/lib/udev/rules.d/90-alsa-restore.rules | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. this file has the following contents - which are not on the LE device
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure if this is directed to me. If it is, I'm not sure if I understand. How are they not on the device? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Nothing here - where is /etc/alsa/state-daemon.conf being created?
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, didn't realize you were referring to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Does this need to be addressed/adjusted /tuned with our planned use of alsa? (As previously this rules file was removed from the build). So when does the udev get used, versus the systemd? |
||
|
||
mkdir -p ${INSTALL}/.noinstall | ||
for i in aconnect alsamixer amidi aplaymidi arecord arecordmidi aseqdump aseqnet iecset; do | ||
for i in aconnect amidi aplaymidi arecord arecordmidi aseqdump aseqnet; do | ||
mv ${INSTALL}/usr/bin/${i} ${INSTALL}/.noinstall | ||
done | ||
|
||
mkdir -p ${INSTALL}/usr/lib/udev | ||
cp ${PKG_DIR}/scripts/soundconfig ${INSTALL}/usr/lib/udev | ||
} |
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
# SPDX-License-Identifier: GPL-2.0-or-later | ||
|
||
d /storage/.cache/alsa 0755 root root - - | ||
L /var/lib/alsa/ - - - - /storage/.cache/alsa | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Look to using the --with-asound-state-dir option in package,mk There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can do, but why? This approach, besides being simple enough, has the added benefit of retaining the standard setup as much as possible. A user familiar with ALSA on desktops for instance, needing to find the state file for whatever reason (say removing it, or trying to figure out why state is not retained), would know where to look for it. This would not be the case, if we reconfigured There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Have a look at prior art, e.g. openssh, where the configure option is applicable it is being used. There are not many links from / into .cache |
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this wasnt doing anything