Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of Geopy for reverse geolocation #1012

Merged
merged 10 commits into from
Sep 10, 2023

Conversation

sickelap
Copy link
Contributor

This will update api_photo.geolocation_json column with normalized location data. Normalized data will be applied to new photos only or when rescanning the library.

@sonarcloud
Copy link

sonarcloud bot commented Sep 10, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 10 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derneuere
Copy link
Member

Welcome Back! 😄 Looks good to me!

@derneuere derneuere merged commit 0e1471c into LibrePhotos:dev Sep 10, 2023
1 of 2 checks passed
@reds2006
Copy link

This will update api_photo.geolocation_json column with normalized location data. Normalized data will be applied to new photos only or when rescanning the library.

Does this mean that soon it will be possible to use other sites besides mapbox to determine geolocation?
Thank you

@derneuere
Copy link
Member

@reds2006 Yes, it's available on the dev branch and can be set in the admin settings.

@sickelap sickelap deleted the refactor_geocode branch September 11, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants