-
-
Notifications
You must be signed in to change notification settings - Fork 101
feat: show signature status on files app #5225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
390e315 to
b10bda8
Compare
vitormattos
commented
Dec 3, 2025
Signed-off-by: David Lima <[email protected]>
Only show signature icon on files of pdf type and if the LibreSign certificate is ok Signed-off-by: David Lima <[email protected]>
Get file status by nodeId Signed-off-by: David Lima <[email protected]>
Change code style, add copyright text and fix end-point response type to pass previously failing tasks Signed-off-by: David Lima <[email protected]>
… ids Change the end-point filter parameter from nodeId to nodeIds, allowing the filtering by multiple node ids Signed-off-by: David Lima <[email protected]>
Update front end calls to /list/list end-point so it passes node ids filter as an array Signed-off-by: David Lima <[email protected]>
Signed-off-by: David Lima <[email protected]>
Change the status icon and label based on the response from the API Signed-off-by: David Lima <[email protected]>
Add the property signedNodeId to the /file/list end-point to show an icon on the original and signed file, according to the signing status Signed-off-by: David Lima <[email protected]>
Alter the Copyright text year to the file creation year Signed-off-by: David Lima <[email protected]>
Send function parameter already with the right name, so a useless if condition is avoided Signed-off-by: David Lima <[email protected]>
Signed-off-by: David Lima <[email protected]>
Add column signed_node_id to getFiesAssociatedFilesWithMeQueryBuilder method query group by Signed-off-by: David Lima <[email protected]>
Signed-off-by: David Lima <[email protected]>
Signed-off-by: David Lima <[email protected]>
…id on libresign files Signed-off-by: David Lima <[email protected]>
…d on the file attributes Signed-off-by: David Lima <[email protected]>
Signed-off-by: David Lima <[email protected]>
Signed-off-by: David Lima <[email protected]>
Signed-off-by: David Lima <[email protected]>
Signed-off-by: David Lima <[email protected]>
Signed-off-by: David Lima <[email protected]>
Signed-off-by: Vitor Mattos <[email protected]>
… icon Signed-off-by: Vitor Mattos <[email protected]>
91138b6 to
282ff04
Compare
When clicking on the signature status inline icon, it now opens the LibreSign sidebar tab for the file, providing quick access to signature details and actions. Signed-off-by: Vitor Mattos <[email protected]>
Apply guard clauses pattern to reduce indentation and improve code readability by returning early when conditions are not met. Signed-off-by: Vitor Mattos <[email protected]>
The registerDavProperty function from @nextcloud/files is deprecated. Use the non-deprecated import from @nextcloud/files/dav instead. Signed-off-by: Vitor Mattos <[email protected]>
The method name is self-explanatory, making the docblock comment unnecessary. Signed-off-by: Vitor Mattos <[email protected]>
Add libresign- prefix to DAV properties (signature-status and signed-node-id) to follow Nextcloud naming conventions and avoid potential naming conflicts with other apps. Signed-off-by: Vitor Mattos <[email protected]>
d411ba4 to
9664ed9
Compare
When fileIdExists performs a database query, store the results in the file property to implement proper lazy loading and avoid redundant queries. Signed-off-by: Vitor Mattos <[email protected]>
Add Behat integration test to validate that LibreSign properties are correctly injected into WebDAV PROPFIND responses. Signed-off-by: Vitor Mattos <[email protected]>
Add new Behat steps for WebDAV testing: - user :user uploads file :source to :path - user :user gets WebDAV properties for :path - the WebDAV response should contain property :property with value :value - fetch WebDAV property :property to :alias Include helper methods davRequest() and parseXml() to avoid duplication. Signed-off-by: Vitor Mattos <[email protected]>
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable31 |
1 task
|
The backport to # Switch to the target branch and update it
git checkout stable32
git pull origin stable32
# Create the new backport branch
git checkout -b backport/5225/stable32
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 1bceacfb b7da03fe cee739a8 a712b3bc 77499f35 d6e00932 55c19628 7bc299be 68d5cfc6 8b1936a1 d17e426f 79cb8dbf 46a253bc 58e2da19 a495a480 370d1ecb ca743594 ab994c42 d47ab739 09df58de ae449c2b 11eb0487 a0b77abf 282ff04c b5c10808 440a72e6 ebf107f2 c82875fc 9664ed97 eac9a458
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/5225/stable32Error: Failed to push branch backport/5225/stable32: fatal: could not read Username for 'https://github.com': No such device or address Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Member
Author
|
/backport to stable32 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This pull request adds an icon to the right of the files, in the files app, showing the file signature status on the original and the signed files. The original will have the status 'Original file signed elsewhere' and the signed file will have the status 'Partially signed' and 'Signed', depending on the signing progress.
To test the feature, after checking out to the pull request:
Related Issue
Issue Number: #4160
Pull Request Type
Pull request checklist