fix: remove duplicate extension #5951
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a document is sent from Files app with the extension already
in the name (e.g., 'test.pdf'), it was being stored as is and would
later display with duplicate extension ('test.pdf.pdf').
This commit adds a method to remove the extension from the document
name before saving if it matches the extension stored in metadata.
The removal is case-insensitive to handle .pdf, .PDF, .Pdf, etc.
Signed-off-by: Vitor Mattos <[email protected]>
Apply the same extension removal logic when formatting file list responses. This ensures that files displayed in the list view don't show duplicate extensions (e.g., 'test.pdf.pdf'). The method checks the metadata for the file extension and removes it from the name if present, maintaining consistency with the save operation. Signed-off-by: Vitor Mattos <[email protected]>
Fix Psalm errors by handling the case where preg_replace might return null. Use null coalescing operator to fallback to the original name if preg_replace fails. Signed-off-by: Vitor Mattos <[email protected]>
Member
Author
|
/backport to stable32 |
Member
Author
|
/backport to stable31 |
github-project-automation
bot
moved this from 0. Needs triage
to 4. to release
in Roadmap
This was referenced Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.