-
Notifications
You must be signed in to change notification settings - Fork 265
Feat/workers per api instance #646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Feat/workers per api instance #646
Conversation
- `_resolve_workers_per_device_config` make `resolve_workers_per_device` into dict[api_path, workers_per_device_int] - `_inference_workers_config_for_api` to instantiate workers per device
|
The CI and e2e tests stuck at |
…id` by iterating through APIs since the number of workers can now vary per API
for more information, see https://pre-commit.ci
|
Precommit and tests successful. I hope this PR could get reviewed |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #646 +/- ##
===================================
- Coverage 85% 85% -0%
===================================
Files 39 39
Lines 3212 3261 +49
===================================
+ Hits 2721 2762 +41
- Misses 491 499 +8 🚀 New features to boost your workflow:
|
|
Hmmm, failed on macos. Any suggestion? |
|
request for review. Need approval for pending checks, cc @bhimrazy @aniketmaurya |
|
I've see that all tests (automatic and dispatch) and codecov is passed. Looking to see review about this PR |
|
Weird, it passed before in 3.12. Can elaborate @bhimrazy? |
|
@bhimrazy looks like in main it is passed now, but somehow only fail in ubuntu 3.10 |
yeah, it could be another flaky test 😅 |
|
I actually have no clue here, should I make some change or else? @bhimrazy |
Maybe try triggering the CI again with an empty commit. btw, we’re still waiting on a review/decision from @andyland @aniketmaurya. |
|
Alright, I've added some minimal comment commit to trigger the test. Can you retrigger the pending checks? @bhimrazy |
|
Seems like it passed all the checks required, looking for review of the code owner. cc @bhimrazy @aniketmaurya |
What does this PR do?
Added feature requested on enabling ability to control
workers_per_deviceper API instance #572 .Before submitting
Tests are passing locally. I added coverage in
tests/unit/test_lit_server.pyand verifiedOn my device (4 x T4) the tests results in:
Repro (4× T4):
PR review
Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.
Did you have fun?
Definitely!