Add tests for NumPy language context and fix import path #2690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aobolensk
commented
Oct 23, 2025
aobolensk
commented
- Fix langctx module import in thunder.numpy
- Add basic tests for thunder.numpy module
- Fix langctx module import in thunder.numpy - Add basic tests for thunder.numpy module
aobolensk
requested review from
KaelanDt,
lantiga,
mruberry and
t-vi
as code owners
IvanYashchuk
approved these changes
Nov 20, 2025
Collaborator
IvanYashchuk
left a comment
IvanYashchuk
left a comment
There was a problem hiding this comment.
There's no harm in merging this PR. However, the untested state of the NumPy language context suggests that it hasn't been one of the most important aspects of Thunder for a while. It may be time to retire it and lighten the codebase.
riccardofelluga
approved these changes
Nov 20, 2025
Collaborator
riccardofelluga
left a comment
riccardofelluga
left a comment
There was a problem hiding this comment.
Thank you for your contribution! just a few nits and questions
Comment on lines
+14
to
+16
| assert len(t) == 2 # axis 0 length | ||
| assert t.size() == 6 # total elements | ||
| assert np_size(t) == 6 |
Collaborator
There was a problem hiding this comment.
Why did you choose to test these?
Contributor
Author
There was a problem hiding this comment.
I needed to check that any numpy function is actually working correctly under the context manager. If you have any better ideas for testing, please, suggest one, I'm ready to fix
|
|
||
|
|
||
| def test_numpy_langctx_registration_and_len_size(): | ||
| with detached_trace(): |
| from collections.abc import Callable | ||
|
|
||
| from thunder.core.langctx import langctx, Languages | ||
| from thunder.core.langctxs import langctx, Languages |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.