Skip to content

Conversation

@aobolensk
Copy link
Contributor

Enable back zero-size test cases that are actually passing

@aobolensk aobolensk marked this pull request as draft October 27, 2025 17:29
@aobolensk aobolensk marked this pull request as ready for review October 27, 2025 17:36
@aobolensk aobolensk force-pushed the zero-shape-unary-tests branch from 4453db6 to f98bf42 Compare October 30, 2025 08:27
Copy link
Collaborator

@IvanYashchuk IvanYashchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great that tests are passing! Supporting 0-sized tensors is a niche but an important usability feature, better not to regress on this accidentally.

@IvanYashchuk
Copy link
Collaborator

@KaelanDt, I don't have the Lightning account to view CI logs. Could you please review the changes and CI failures if they are related?

@riccardofelluga riccardofelluga self-requested a review November 20, 2025 14:40
Copy link
Collaborator

@riccardofelluga riccardofelluga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for enabling this again!

There seems to be some related failures in the logs:

thunder/tests/distributed/test_dtensor.py::DTensorTest::test_dtensor_opinfo_neg_nvfuser
thunder/tests/distributed/test_dtensor.py::DTensorTest::test_dtensor_opinfo_silu_nvfuser
thunder/tests/distributed/test_dtensor.py::DTensorTest::test_dtensor_opinfo_reciprocal_nvfuser

Would you be able to investigate? If that is not possible, could you add a skip to those nvFuser tests and open a new issue?

@aobolensk
Copy link
Contributor Author

aobolensk commented Nov 20, 2025

Thank you for enabling this again!

There seems to be some related failures in the logs:

thunder/tests/distributed/test_dtensor.py::DTensorTest::test_dtensor_opinfo_neg_nvfuser
thunder/tests/distributed/test_dtensor.py::DTensorTest::test_dtensor_opinfo_silu_nvfuser
thunder/tests/distributed/test_dtensor.py::DTensorTest::test_dtensor_opinfo_reciprocal_nvfuser

Would you be able to investigate? If that is not possible, could you add a skip to those nvFuser tests and open a new issue?

@riccardofelluga Ok, that explains better what is going on, thanks for sharing! So it seems 0-shape tensors are not really working well on nvFuser backend, but as for other backends it is fine. Unfortunately, I'm not ready to fix nvFuser backend specific stuff (no HW available). I was actually observing that everything is good on CPU.

Does it make sense for you to enable them globally, but skip again only for nvFuser?

In this case, we will increase code coverage on some targets at least.

@riccardofelluga
Copy link
Collaborator

@aobolensk Ok, that explains better what is going on, thanks for sharing! So it seems 0-shape tensors are not really working well on nvFuser backend, but as for other backends it is fine. Unfortunately, I'm not ready to fix nvFuser backend specific stuff (no HW available). I was actually observing that everything is good on CPU.

Does it make sense for you to enable them globally, but skip again only for nvFuser?

In this case, we will increase code coverage on some targets at least.

Thanks for checking! Yess it does totally make sense to skip nvFuser ones but let's also open an issue for it so that we can track it in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants