Allow cross-device local checkpoints with fsspec>=2025.5.0
#20780
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cross-device transactions via fsspec (used for example in ModelCheckpoint) resulted in permission errors. The permission errors were caused by attempts to change file modes on different filesystem. This was fixed in fsspec 2025.3.3. Closes #20270
github-actions
bot
added
fabric
siemdejong
changed the title
fsspec>=2025.3.3
|
This PR is on hold pending the PyPI release of fsspec with a fix introduced in fsspec/filesystem_spec#1829. |
siemdejong
changed the title
fsspec>=2025.3.3fsspec>=2025.5.0
|
TODO
|
for more information, see https://pre-commit.ci
…ub.com/siemdejong/pytorch-lightning into bugfix/20270_invalid-cross-device-link
siemdejong
requested review from
lantiga,
Borda,
tchaton,
justusschock and
ethanwharris
as code owners
Borda
reviewed
May 23, 2025
tests/tests_pytorch/trainer/connectors/test_checkpoint_connector.py
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #20780 +/- ##
=======================================
- Coverage 87% 87% -0%
=======================================
Files 268 268
Lines 23368 23373 +5
=======================================
+ Hits 20330 20334 +4
- Misses 3038 3039 +1 |
Borda
approved these changes
May 27, 2025
Borda
pushed a commit
that referenced
this pull request
Jun 19, 2025
Cross-device transactions via fsspec (used for example in ModelCheckpoint) resulted in permission errors. The permission errors were caused by attempts to change file modes on different filesystem. This was fixed in fsspec 2025.3.3. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> (cherry picked from commit a83fcef)
sudiptob2
pushed a commit
to sudiptob2/pytorch-lightning
that referenced
this pull request
Jun 27, 2025
…ng-AI#20780) Cross-device transactions via fsspec (used for example in ModelCheckpoint) resulted in permission errors. The permission errors were caused by attempts to change file modes on different filesystem. This was fixed in fsspec 2025.3.3. --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Cross-device transactions via fsspec (used for example in ModelCheckpoint) resulted in permission errors (#20270). The permission errors were caused by attempts to change file modes on different filesystem. This was fixed in fsspec 2025.5.0. This PR proposes to increase the minimum version to
fsspec>=2025.5.0.Fixes #20270
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--20780.org.readthedocs.build/en/20780/