Skip to content

Conversation

Borda
Copy link
Member

@Borda Borda commented Sep 9, 2025

What does this PR do?

since the litCI does not use these pre-build images and Azure is going to be deprecated, there is no need to preserve this docker builds and updates

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21190.org.readthedocs.build/en/21190/

@Borda Borda requested a review from Copilot September 9, 2025 16:22
@github-actions github-actions bot added ci Continuous Integration dockers labels Sep 9, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes all Docker-related infrastructure and CI configurations as they are no longer needed since litCI doesn't use pre-built images and Azure infrastructure is being deprecated.

  • Removes all Docker configuration files (Dockerfiles and README)
  • Updates CI configuration to remove Docker-related labeling and checks
  • Eliminates Docker build workflows from the required CI checks

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
dockers/release/Dockerfile Removed Docker configuration for release builds
dockers/nvidia/Dockerfile Removed NVIDIA-specific Docker configuration
dockers/docs/Dockerfile Removed documentation Docker configuration
dockers/base-cuda/Dockerfile Removed base CUDA Docker configuration
dockers/README.md Removed Docker documentation
.github/label-change.yml Removed "dockers" label configuration for automated labeling
.github/checkgroup.yml Removed Docker build checks from required CI workflows

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

github-actions bot commented Sep 9, 2025

⚡ Required checks status: All passing 🟢

No groups match the files changed in this PR.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 60 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@tchaton tchaton merged commit 8612565 into master Sep 10, 2025
20 checks passed
@tchaton tchaton deleted the drop-dockers branch September 10, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous Integration dockers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants