Skip to content

Conversation

SkafteNicki
Copy link
Collaborator

@SkafteNicki SkafteNicki commented Sep 23, 2025

What does this PR do?

Fixes #20149

Not completely sure what the best solution to this issue is. The core issue is that webdataset has been updated meaning that the currently linked example to https://github.com/webdataset/webdataset-lightning does not work anymore. So we can either:

  • Correct the small example we have in our own docs to included the needed parameters to get webdataset working (what I have done in this PR)
  • Completely remove the link to the example and hope users figure out the integration themself
  • Create an updated integration example and link to that
Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21243.org.readthedocs.build/en/21243/

@SkafteNicki SkafteNicki added the docs Documentation related label Sep 23, 2025
@SkafteNicki SkafteNicki added the 3rd party Related to a 3rd-party label Sep 23, 2025
@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3rd party Related to a 3rd-party docs Documentation related pl Generic label for PyTorch Lightning package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to use Webdataset in DDP setting? ValueError: you need to add an explicit nodesplitter to your input pipeline for multi-node training
3 participants