-
Notifications
You must be signed in to change notification settings - Fork 3.6k
tests for python version in req. for split dependencies #21305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
⛈️ Required checks status: Has failure 🔴
Groups summary🟢 pytorch_lightning: Tests workflow
These checks are required after the changes to 🔴 pytorch_lightning: lit GPU
These checks are required after the changes to 🟢 pytorch_lightning: Docs
These checks are required after the changes to 🟢 lightning_fabric: CPU workflow
These checks are required after the changes to 🔴 lightning_fabric: lit GPU
These checks are required after the changes to 🟢 mypy
These checks are required after the changes to 🟢 install
These checks are required after the changes to Thank you for your contribution! 💜
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Align environment markers in test requirements to use exclusive lower-bound comparisons for Python versions.
- Replace python_version >= "3.10" with python_version > "3.9" to avoid potential lexicographic pitfalls
- Mirror the same change for torch-tensorrt (>= "3.12" to > "3.11")
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
File | Description |
---|---|
requirements/pytorch/test.txt | Adjusts environment markers for pytest-rerunfailures and torch-tensorrt to use > previous-minor style. |
requirements/fabric/test.txt | Adjusts environment marker for pytest-rerunfailures to use > previous-minor style. |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #21305 +/- ##
========================================
- Coverage 87% 87% -1%
========================================
Files 269 269
Lines 23707 23707
========================================
- Hits 20682 20546 -136
- Misses 3025 3161 +136 |
This reverts commit a74bc32.
What does this PR do?
used
>=
would be replacd by==
Before submitting
PR review
Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:
Reviewer checklist
📚 Documentation preview 📚: https://pytorch-lightning--21305.org.readthedocs.build/en/21305/