Skip to content

Conversation

Borda
Copy link
Collaborator

@Borda Borda commented Oct 20, 2025

What does this PR do?

used >= would be replacd by ==

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21305.org.readthedocs.build/en/21305/

@github-actions github-actions bot added fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package dependencies Pull requests that update a dependency file labels Oct 20, 2025
Copy link
Contributor

github-actions bot commented Oct 20, 2025

⛈️ Required checks status: Has failure 🔴

Warning
This job will need to be re-run to merge your PR. If you do not have write access to the repository, you can ask Lightning-AI/lai-frameworks to re-run it. If you push a new commit, all of CI will re-trigger.

Groups summary

🟢 pytorch_lightning: Tests workflow
Check ID Status
pl-cpu-guardian success

These checks are required after the changes to .actions/assistant.py.

🔴 pytorch_lightning: lit GPU
Check ID Status
pytorch.yml / Lit Job (nvidia/cuda:12.1.1-runtime-ubuntu22.04, pytorch, 3.10) failure
pytorch.yml / Lit Job (lightning, 3.12) failure
pytorch.yml / Lit Job (pytorch, 3.12) failure

These checks are required after the changes to .actions/assistant.py.

🟢 pytorch_lightning: Docs
Check ID Status
docs-make (pytorch, doctest) success
docs-make (pytorch, html) success

These checks are required after the changes to .actions/assistant.py.

🟢 lightning_fabric: CPU workflow
Check ID Status
fabric-cpu-guardian success

These checks are required after the changes to .actions/assistant.py.

🔴 lightning_fabric: lit GPU
Check ID Status
fabric.yml / Lit Job (nvidia/cuda:12.1.1-runtime-ubuntu22.04, fabric, 3.10) success
fabric.yml / Lit Job (fabric, 3.12) success
fabric.yml / Lit Job (lightning, 3.12) failure

These checks are required after the changes to .actions/assistant.py.

🟢 mypy
Check ID Status
mypy success

These checks are required after the changes to .actions/assistant.py.

🟢 install
Check ID Status
install-pkg-guardian success

These checks are required after the changes to .actions/assistant.py.


Thank you for your contribution! 💜

Note
This comment is automatically generated and updates for 70 minutes every 180 seconds. If you have any other questions, contact carmocca for help.

@Borda Borda requested a review from Copilot October 20, 2025 08:54
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Align environment markers in test requirements to use exclusive lower-bound comparisons for Python versions.

  • Replace python_version >= "3.10" with python_version > "3.9" to avoid potential lexicographic pitfalls
  • Mirror the same change for torch-tensorrt (>= "3.12" to > "3.11")

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
requirements/pytorch/test.txt Adjusts environment markers for pytest-rerunfailures and torch-tensorrt to use > previous-minor style.
requirements/fabric/test.txt Adjusts environment marker for pytest-rerunfailures to use > previous-minor style.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87%. Comparing base (7d0d0ad) to head (e6b42a6).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #21305    +/-   ##
========================================
- Coverage      87%      87%    -1%     
========================================
  Files         269      269            
  Lines       23707    23707            
========================================
- Hits        20682    20546   -136     
- Misses       3025     3161   +136     

@github-actions github-actions bot added the ci Continuous Integration label Oct 20, 2025
@Borda Borda changed the title fix python version in req. for split dependencies tests for python version in req. for split dependencies Oct 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Continuous Integration dependencies Pull requests that update a dependency file fabric lightning.fabric.Fabric pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants