Skip to content

Conversation

@Iruos8805
Copy link

@Iruos8805 Iruos8805 commented Nov 12, 2025

What does this PR do?

This PR introduces a new best_model_metrics attribute to the ModelCheckpoint callback, enabling users to directly access all logged training and validation metrics associated with the best model, chosen based on the monitored metric.

Previously, only the best_model_score and best_model_path were available. With this addition, users can easily retrieve the corresponding metrics like val_loss, train_loss, val_metric etc. of the best checkpoint without reloading the model or rerunning validation.

This makes it easier to analyze results and use the best model’s metrics for reporting or hyperparameter tuning.

Fixes #19007

Before submitting
  • Was this discussed/agreed via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

📚 Documentation preview 📚: https://pytorch-lightning--21355.org.readthedocs.build/en/21355/

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pl Generic label for PyTorch Lightning package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add best_model_metrics to ModelCheckpoint callback

1 participant