Repository navigation
perf(cli): skip the parent listing when a drive folder has entries - #220
Merged
Merged
Conversation
lianakoleva
requested review from
ethanwharris,
justusschock,
k223kim,
rusenask and
tejapulagam
as code owners
October 29, 2026 16:49
mbeidler
approved these changes
Oct 29, 2026
tejapulagam
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lightning lslisted a folder's parent to confirm the folder exists, then listed the folder again for its contents, so every directory listing cost two drive requests. this is especially costly when the parent of a large folder is large (common when listingstudio/<studio-name>). a non-empty folder listing now returns directly. the parent is only listed when the folder's listing is empty or fails, since an empty folder, a file, and a missing path look the same from the folder alone.evidence
timing command (averaged over 5 runs):
/usr/bin/time -p lightning ls lit://lightning-ai/thunder/studios/zero-to-thunder-xtsp/