Skip to content

feat(be): Stop falling back to the legacy job log download - #222

Open
andyland wants to merge 1 commit into
mainfrom
andy/drop-download-job-logs
Open

andyland wants to merge 1 commit into
mainfrom
andy/drop-download-job-logs

Conversation

@andyland

Copy link
Copy Markdown
Contributor

The Python and Go SDKs stop calling DownloadJobLogs, which gridai/grid#49412 removes along with the rest of the legacy job log endpoints. The platform is offline right now, so no released client can reach those endpoints in the meantime.

  • A finished job with nothing in the logs API now raises "This job's logs are still being migrated from older storage. Try again shortly." instead of downloading its saved page log. Reading the job queues its migration on the backend, so a retry shortly after succeeds.
  • Python: logs, logs(...) and download_logs() raise RuntimeError, and JobApi.get_logs_finished is removed. A filtered read (since, until, query or severity) that comes back empty still probes unfiltered first, so a filter that matched nothing returns "" rather than the migrating error.
  • Go: Job.Logs() returns the same error, and savedLogs is removed.
  • JS already used only the logs API, so it's unchanged.

Tested with go test ./... in go/ and pytest core/test_job.py.

🤖 Generated with Claude Code

— Claude Opus 5.5, on direct instruction; text not reviewed

A finished job with nothing in the logs API now raises "still being
migrated" instead of downloading its page-N log file through
DownloadJobLogs, which gridai/grid is removing. Reading the job queues
its migration, so a retry shortly after succeeds.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@andyland
andyland enabled auto-merge (squash) October 29, 2026 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants