Repository navigation
fix: sign in with the session-token login unless LIGHTNING_CLI_OIDC_LOGIN is set - #227
Merged
Merged
Conversation
…IDC_LOGIN is set #221 switched `lightning login` to the authorization-code login, which opens /oidc/authorize. The control plane only serves that with GRID_AUTH_CLI_LOGIN_ENABLED, which production doesn't set yet, so on v2026.11.02 `lightning login` lands on the web app's 404 page. `lightning login` goes back to the v2026.10.27 session-token login by default. LIGHTNING_CLI_OIDC_LOGIN=1 opts in to the authorization-code login, and to `--no-browser`, for testing against an environment that serves it. `--no-browser` is hidden from help and refused without the opt-in, before any saved credentials are cleared. The README and CLI docs no longer mention it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Agent-Harness: claude-code
ethanwharris
requested review from
dhedey,
justusschock,
k223kim,
owbone,
rusenask and
tejapulagam
as code owners
November 3, 2026 10:13
ethanwharris
changed the title
k223kim
approved these changes
Nov 3, 2026
justusschock
approved these changes
Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes CLI login, putting the new OIDC stuff behind an env var for testing.
Agent
#221 switched
lightning loginto the authorization-code login, which opens /oidc/authorize. The control plane only serves that with GRID_AUTH_CLI_LOGIN_ENABLED, which production doesn't set yet, so on v2026.11.02lightning loginlands on the web app's 404 page.lightning logingoes back to the v2026.10.27 session-token login by default. LIGHTNING_CLI_OIDC_LOGIN=1 opts in to the authorization-code login, and to--no-browser, for testing against an environment that serves it.--no-browseris hidden from help and refused without the opt-in, before any saved credentials are cleared. The README and CLI docs no longer mention it.