Skip to content

Conversation

@Borda
Copy link
Collaborator

@Borda Borda commented Aug 18, 2025

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did all existing and newly added tests pass locally?

What does this PR do?

addressing

    _TORCHMETRICS_GREATER_EQUAL_1_0_0 = compare_version("torchmetrics", operator.ge, "1.0.0")
../.venv/lib/python3.10/site-packages/lightning_utilities/core/imports.py:78: in compare_version
    pkg = importlib.import_module(package)
../.venv/lib/python3.10/site-packages/torchmetrics/__init__.py:22: in <module>
    from torchmetrics import functional  # noqa: E402
../.venv/lib/python3.10/site-packages/torchmetrics/functional/__init__.py:14: in <module>
    from torchmetrics.functional.audio._deprecated import _permutation_invariant_training as permutation_invariant_training
../.venv/lib/python3.10/site-packages/torchmetrics/functional/audio/__init__.py:14: in <module>
    from torchmetrics.functional.audio.pit import permutation_invariant_training, pit_permutate
../.venv/lib/python3.10/site-packages/torchmetrics/functional/audio/pit.py:22: in <module>
    from torchmetrics.utilities import rank_zero_warn
../.venv/lib/python3.10/site-packages/torchmetrics/utilities/__init__.py:14: in <module>
    from torchmetrics.utilities.checks import check_forward_full_state_property
../.venv/lib/python3.10/site-packages/torchmetrics/utilities/checks.py:25: in <module>
    from torchmetrics.metric import Metric
../.venv/lib/python3.10/site-packages/torchmetrics/metric.py:30: in <module>
    from torchmetrics.utilities.data import (
../.venv/lib/python3.10/site-packages/torchmetrics/utilities/data.py:22: in <module>
    from torchmetrics.utilities.imports import _TORCH_GREATER_EQUAL_1_12, _XLA_AVAILABLE
../.venv/lib/python3.10/site-packages/torchmetrics/utilities/imports.py:45: in <module>
    _TORCHVISION_GREATER_EQUAL_0_8: Optional[bool] = compare_version("torchvision", operator.ge, "0.8.0")
../.venv/lib/python3.10/site-packages/lightning_utilities/core/imports.py:78: in compare_version
    pkg = importlib.import_module(package)
../.venv/lib/python3.10/site-packages/torchvision/__init__.py:10: in <module>
    from torchvision import _meta_registrations, datasets, io, models, ops, transforms, utils  # usort:skip
../.venv/lib/python3.10/site-packages/torchvision/_meta_registrations.py:164: in <module>
    def meta_nms(dets, scores, iou_threshold):
../.venv/lib/python3.10/site-packages/torch/library.py:1069: in register
    use_lib._register_fake(
../.venv/lib/python3.10/site-packages/torch/library.py:219: in _register_fake
    handle = entry.fake_impl.register(
../.venv/lib/python3.10/site-packages/torch/_library/fake_impl.py:51: in register
    raise RuntimeError(
E   RuntimeError: register_fake(...): the operator torchvision::nms already has an DispatchKey::Meta implementation via a pre-existing torch.library or TORCH_LIBRARY registration. Please either remove that registration or don't call register_fake.

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in GitHub issues there's a high chance it will not be merged.


📚 Documentation preview 📚: https://lit-utilities--427.org.readthedocs.build/en/427/

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the compare_version function to handle RuntimeError exceptions that can occur during module import, specifically addressing a torchvision registration conflict that was causing crashes.

  • Expands exception handling in compare_version to catch RuntimeError in addition to ImportError

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@Borda Borda merged commit 9b23a6a into main Aug 18, 2025
59 checks passed
@Borda Borda deleted the fix/compare_version branch August 18, 2025 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant