Fix docs around name for distilled LORA path VAR#26
Closed
q5sys wants to merge 1 commit intoLightricks:mainfrom
Closed
Fix docs around name for distilled LORA path VAR#26q5sys wants to merge 1 commit intoLightricks:mainfrom
q5sys wants to merge 1 commit intoLightricks:mainfrom
Conversation
I figure its eaiser to fix the docs than the code since runners may exist that already depend on the exact VAR name.
Docs say:
`--distilled-lora-path path/to/distilled_lora.safetensors \`
@ https://github.com/Lightricks/LTX-2/edit/main/packages/ltx-pipelines/README.md
but the code says:
`distilled_lora: list[LoraPathStrengthAndSDOps],`
@ https://github.com/Lightricks/LTX-2/blob/main/packages/ltx-pipelines/src/ltx_pipelines/ti2vid_two_stages.py#L52
Which causes a failure when the docs are followed:
```
python -m ltx_pipelines.ti2vid_two_stages \
--checkpoint-path /zstor/ai/ltx2/LTX-2/ltx-2-19b-dev.safetensors \
--distilled-lora-path /zstor/ai/ltx2/LTX-2/ltx-2-19b-distilled-lora-384.safetensors \
--spatial-upsampler-path /zstor/ai/ltx2/LTX-2/ltx-2-spatial-upscaler-x2-1.0.safetensors \
--gemma-root /zstor/ai/ltx2/ComfyUI/models/text_encoders/gemma_3_12B/ \
--prompt "a beautiful sunset over the ocean" \
--negative-prompt "blurry, out of focus" \
--output-path output.mp4 \
--height 480 \
--width 720 \
--frame-rate 24 \
--num-frames 96 \
--num-inference-steps 40 \
--cfg-guidance-scale 4 \
--seed 42 \
--enable-fp8
```
Error:
`ti2vid_two_stages.py: error: the following arguments are required: --distilled-lora`
Author
|
derp... didn't check to see if there was already a PR for this. Turns out #20 covers it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I figure its eaiser to fix the docs than the code since runners may exist that already depend on the exact VAR name.
Docs say:
--distilled-lora-path path/to/distilled_lora.safetensors \@ https://github.com/Lightricks/LTX-2/edit/main/packages/ltx-pipelines/README.mdbut the code says:
distilled_lora: list[LoraPathStrengthAndSDOps],@ https://github.com/Lightricks/LTX-2/blob/main/packages/ltx-pipelines/src/ltx_pipelines/ti2vid_two_stages.py#L52
Which causes a failure when the docs are followed:
Error:
ti2vid_two_stages.py: error: the following arguments are required: --distilled-lora