14주차 Assignment - 최진원 #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
과제 통과입니다~!!몇 가지 개선해 보면 좋을 부분 코멘트 달아놨으니 참고해 보시면 좋을 것 같아요! |
yengniws
reviewed
Nov 15, 2025
| }; | ||
|
|
||
| const editUserName = async (id, currentName) => { // PATCH | ||
| const newName = window.prompt("새 닉네임을 입력하세요.", currentName); |
There was a problem hiding this comment.
프롬프트 대신 UserCard 내에서 인풋을 통해 닉네임을 수정하는 방식이 사용자 입장에서 더 깔끔하고 편리할 것 같습니다!!
| <UserForm onAddUser={addUser} disabled={loading} /> | ||
|
|
||
| <div className="mt-2 mb-4"> | ||
| {loading && (<p className="text-sm text-slate-600">로딩 중입니다. 잠시만요…</p>)} |
| const [name, setName] = useState(""); | ||
| const [email, setEmail] = useState(""); | ||
|
|
||
| const handleSubmit = (e) => { |
There was a problem hiding this comment.
닉네임과 이메일 둘 중 하나가 입력이 되지 않은 상태에서 추가 버튼을 누르면 입력한 내용이 비워지고 있어요!
이 부분은 어떻게 해결하면 좋을까요?
둘 중 하나가 입력이 되지 않은 상태에선 alert 메세지를 띄우는 것도 좋은 방법일 것 같습니다~!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Important content
Question
X
Reference
crud 기능 구현
https://leeseohyun430.tistory.com/91
Image
X