Implement /post/game route #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konsumlamm
requested changes
Aug 28, 2022
| #[post("/post/game")] | ||
| async fn post_game(data: Data<RwLock<AppData>>, game: Json<GameStats>) -> impl Responder { | ||
| let res = { | ||
| let mut data = data.write().unwrap(); // Needs better error handling -- esp. with if the RwLock is poisoned |
There was a problem hiding this comment.
Suggested change
| let mut data = data.write().unwrap(); // Needs better error handling -- esp. with if the RwLock is poisoned | |
| let mut data = data.write().unwrap(); // Needs better error handling -- esp. with if the RwLock is poisoned |
We could use parking_lot, which has an RwLock without poisoning.
Comment on lines
+116
to
+117
| data.stats.merge(stats); | ||
| data.games.push(game); |
There was a problem hiding this comment.
Do we want to check if the game is already present (by checking the round_date)?
There was a problem hiding this comment.
We should check if the game already exists (by comparing the round date) and return an appropriate response (an error or something like an empty JSON) in that case.
Co-authored-by: konsumlamm <[email protected]>
TrueDoctor
reviewed
Aug 28, 2022
konsumlamm
reviewed
Mar 10, 2023
| serde_repr = "0.1" | ||
| serde_repr = "0.1" |
There was a problem hiding this comment.
Can you readd the trailing newline?
Comment on lines
+120
to
+136
| impl<T> Merge for Option<T> | ||
| where | ||
| T: Merge, | ||
| { | ||
| fn merge(&mut self, other: Self) { | ||
| match (self, other) { | ||
| // (Some, Some) | ||
| (Some(v), Some(other)) => v.merge(other), | ||
|
|
||
| // (None, Some) | ||
| (s, Some(other)) => *s = Some(other), | ||
|
|
||
| // (None, None) or (Some, None) | ||
| _ => (), | ||
| } | ||
| } | ||
| } |
konsumlamm
reviewed
Mar 10, 2023
| @@ -1,2911 +1,4114 @@ | |||
| { | |||
| "KillFeed":[{ | |||
There was a problem hiding this comment.
Can you undo this reformat?
Co-authored-by: konsumlamm <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would have the benefit of adding games while the server is running.
But it would slow down initial building of the stats.