Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: demonet network config #453

Merged
merged 2 commits into from
Nov 26, 2024
Merged

feat: demonet network config #453

merged 2 commits into from
Nov 26, 2024

Conversation

noryev
Copy link
Contributor

@noryev noryev commented Nov 26, 2024

Summary

This pull request makes the following changes:

  • Add a configuration file for the new Lilypad Demonet network

These changes are to allow a user to use the --demonet network via a CLI job to point the Lilypad job to the Demonet network instead of the Testnet network.

Task/Issue reference

#430

Test plan

  • When running the code from source go run . --network demonet github.com/lilypad-tech/lilypad-module-lilysay:0.5.2

  • When using the lilypad CLI, use lilypad run --network demonet github.com/lilypad-tech/lilypad-module-lilysay:0.5.2

@noryev noryev requested a review from a team as a code owner November 26, 2024 16:12
@cla-bot cla-bot bot added the cla-signed label Nov 26, 2024
@noryev noryev changed the title add demonet network config feat: Demonet network config Nov 26, 2024
@noryev noryev changed the title feat: Demonet network config feat: demonet network config Nov 26, 2024
We are not running the api host on demonet, and setting an empty string disables calls to the api.
Copy link
Contributor

@bgins bgins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Running jobs on demonet works! 💖

@noryev noryev merged commit 732b5ad into main Nov 26, 2024
4 checks passed
@noryev noryev deleted the noryev/feat-add-demonet branch November 26, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants