-
Notifications
You must be signed in to change notification settings - Fork 123
Add rollback test definition files for LoL testing #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
489b248 to
d032505
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a lot of duplication between this file and automated/linux/torizon/ostree-upgrade-tests.sh... Can we create a common functions that you can source in both tests.
| echo """ | ||
| #!/bin/bash | ||
| exit 1 | ||
| """ >> /etc/greenboot/check/required.d/rollback.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we assume that this directory is created, should we check that first?
or always add "mkdir -p /etc/greenboot/check/required.d/" ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if that's not present in the OS, something is very wrong and the job should fail :)
54d0a8c to
5e41168
Compare
129493a to
f972f65
Compare
We can fake the failed upgrade by setting the rollback.sh script to exit with 1 and setting the specific uefi variables. Signed-off-by: Stevan Radaković <[email protected]>
f972f65 to
7578cc6
Compare
Separate PR or this one with another commit? |
maybe better to first merge this and then do a small refactoring PR where we will move the common code in a separate file and update both scripts. |
|
Replaced by #605 |
We can fake the failed upgrade by setting the rollback.sh script to exit with 1 and setting the specific uefi variables.