Skip to content

Conversation

@stevanradakovic
Copy link
Contributor

We can fake the failed upgrade by setting the rollback.sh script to exit with 1 and setting the specific uefi variables.

Copy link
Collaborator

@roxell roxell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a lot of duplication between this file and automated/linux/torizon/ostree-upgrade-tests.sh... Can we create a common functions that you can source in both tests.

echo """
#!/bin/bash
exit 1
""" >> /etc/greenboot/check/required.d/rollback.sh
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we assume that this directory is created, should we check that first?
or always add "mkdir -p /etc/greenboot/check/required.d/" ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if that's not present in the OS, something is very wrong and the job should fail :)

@stevanradakovic stevanradakovic force-pushed the master branch 9 times, most recently from 54d0a8c to 5e41168 Compare October 16, 2025 12:51
@stevanradakovic stevanradakovic force-pushed the master branch 3 times, most recently from 129493a to f972f65 Compare October 22, 2025 08:40
We can fake the failed upgrade by setting the rollback.sh script
to exit with 1 and setting the specific uefi variables.

Signed-off-by: Stevan Radaković <[email protected]>
@stevanradakovic
Copy link
Contributor Author

I see a lot of duplication between this file and automated/linux/torizon/ostree-upgrade-tests.sh... Can we create a common functions that you can source in both tests.

Separate PR or this one with another commit?

@stevanradakovic
Copy link
Contributor Author

I see a lot of duplication between this file and automated/linux/torizon/ostree-upgrade-tests.sh... Can we create a common functions that you can source in both tests.

Separate PR or this one with another commit?

maybe better to first merge this and then do a small refactoring PR where we will move the common code in a separate file and update both scripts.

@ivoire
Copy link
Collaborator

ivoire commented Oct 27, 2025

Replaced by #605

@ivoire ivoire closed this Oct 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants