Add HPE LTO-10 drives to the supported drive list#604
Open
matejk wants to merge 1 commit into
Open
Conversation
HPE LTO-10 drives are not recognized by the sg/iokit backends because hp_supported_drives[] stops at generation 9; unlisted drives are rejected with EDEV_DEVICE_UNSUPPORTABLE. Add both the "Ultrium A-SCSI" product ID (generation A naming, as used by IBM ULTRIUM-TDA) and "Ultrium 10-SCSI" (HPE's established naming pattern). Timeout handling for DRIVE_LTO10 is already in place.
Member
|
Hi there @matejk ! Thanks for your contribution, I was not aware that HPE already had LTO 10 tape drives, I was searching online but only found cartridges, could you please share a source just to keep it in mind? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hp_supported_drives[]currently stops at generation 9, so HPE LTO-10 drives are rejected by the sg and iokit backends withEDEV_DEVICE_UNSUPPORTABLE(drive identification insg_tape.c/iokit_tape.conly accepts product IDs found in the vendor tables).This adds two entries mapping to
DRIVE_LTO10:Ultrium A-SCSI— generation "A" naming, matching the convention IBM uses for its Gen 10 drives (ULTRIUM-TDA,ULT3580-TDA).Ultrium 10-SCSI— HPE's established product ID pattern (Ultrium 8-SCSI,Ultrium 9-SCSI, ...).No other changes are needed:
hp_tape_init_timeout()already handlesDRIVE_LTO10/DRIVE_LTO10_HH, and the error/density handling is generation-independent.