Skip to content

Commit

Permalink
Update flag names and aliases to preserve backwards compatibility
Browse files Browse the repository at this point in the history
Signed-off-by: Brett Logan <[email protected]>
  • Loading branch information
lindluni committed Sep 15, 2023
1 parent 744de1d commit c15b57b
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
12 changes: 6 additions & 6 deletions internal/generate_flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@ func GenerateFlags() []cli.Flag {
Name: "app-id",
Usage: "GitHub App ID",
Required: true,
Aliases: []string{"a"},
Aliases: []string{"i", "app_id"},
},
&cli.StringFlag{
Name: "installation-id",
Usage: "GitHub App installation ID. Defaults to the first installation returned by the GitHub API if not specified",
Required: false,
Aliases: []string{"i"},
Aliases: []string{"l", "installation_id"},
},
&cli.StringFlag{
Name: "key",
Expand All @@ -24,10 +24,10 @@ func GenerateFlags() []cli.Flag {
Aliases: []string{"k"},
},
&cli.StringFlag{
Name: "key-base64",
Name: "base64-key",
Usage: "A base64 encoded private key",
Required: false,
Aliases: []string{"b"},
Aliases: []string{"b", "base64_key"},
},
&cli.StringFlag{
Name: "hostname",
Expand All @@ -50,10 +50,10 @@ func GenerateFlags() []cli.Flag {
Value: false,
},
&cli.IntFlag{
Name: "jwt-expiry",
Name: "duration",
Usage: "The expiry time of the JWT in minutes up to a maximum value of 10, useful when using the --jwt flag",
Required: false,
Aliases: []string{"e"},
Aliases: []string{"d"},
Value: 1,
},
&cli.BoolFlag{
Expand Down
6 changes: 3 additions & 3 deletions internal/installations_flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ func InstallationsFlags() []cli.Flag {
Name: "app-id",
Usage: "GitHub App ID",
Required: true,
Aliases: []string{"a"},
Aliases: []string{"i", "app_id"},
},
&cli.StringFlag{
Name: "key",
Expand All @@ -18,10 +18,10 @@ func InstallationsFlags() []cli.Flag {
Aliases: []string{"k"},
},
&cli.StringFlag{
Name: "key-base64",
Name: "base64-key",
Usage: "A base64 encoded private key",
Required: false,
Aliases: []string{"b"},
Aliases: []string{"b", "base64_key"},
},
&cli.StringFlag{
Name: "hostname",
Expand Down

0 comments on commit c15b57b

Please sign in to comment.