Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add webhook bearer auth support #619

Merged
merged 6 commits into from
Feb 15, 2025
Merged

Conversation

LinuxSuRen
Copy link
Owner

We highly recommend you read the contributor's documentation before starting the review process especially since this is your first contribution to this project.

It was updated on 2024/5/27

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

@LinuxSuRen LinuxSuRen added the enhancement New feature or request label Feb 11, 2025
Copy link

github-actions bot commented Feb 11, 2025

There are 1 test cases, failed count 0:

Name Average Max Min Count Error
9.886111ms 10.54519ms 9.396278ms 3 0

Reported by api-testing.

w.Write([]byte(err.Error()))
}
if err == nil {
w.Write(data)

Check warning

Code scanning / CodeQL

Reflected cross-site scripting Medium

Cross-site scripting vulnerability due to
user-provided value
.

Copilot Autofix AI 16 days ago

To fix the reflected cross-site scripting vulnerability, we need to ensure that any user-controlled data is properly sanitized or escaped before being written to the HTTP response. In this case, we can use the html.EscapeString function from the html package to escape any potentially dangerous characters in the data variable before writing it to the response.

Suggested changeset 1
pkg/mock/in_memory.go

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/pkg/mock/in_memory.go b/pkg/mock/in_memory.go
--- a/pkg/mock/in_memory.go
+++ b/pkg/mock/in_memory.go
@@ -40,2 +40,3 @@
     "github.com/gorilla/mux"
+    "html"
 )
@@ -353,3 +354,4 @@
     if err == nil {
-        w.Write(data)
+        escapedData := html.EscapeString(string(data))
+        w.Write([]byte(escapedData))
     } else {
EOF
@@ -40,2 +40,3 @@
"github.com/gorilla/mux"
"html"
)
@@ -353,3 +354,4 @@
if err == nil {
w.Write(data)
escapedData := html.EscapeString(string(data))
w.Write([]byte(escapedData))
} else {
Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Copy link

codacy-production bot commented Feb 11, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.20% (target: -1.00%) 73.63% (target: 80.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (430d912) 18750 7841 41.82%
Head commit (a89ce37) 19087 (+337) 8020 (+179) 42.02% (+0.20%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#619) 383 282 73.63%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@LinuxSuRen LinuxSuRen requested a review from yuluo-yx as a code owner February 11, 2025 12:50
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

@LinuxSuRen LinuxSuRen merged commit 4b4ee3a into master Feb 15, 2025
20 of 22 checks passed
@LinuxSuRen LinuxSuRen deleted the feat/mock-webhook-auth branch February 15, 2025 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants