Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sensors landing page updates #52

Merged
merged 6 commits into from
Oct 25, 2023
Merged

Sensors landing page updates #52

merged 6 commits into from
Oct 25, 2023

Conversation

crystalgardner
Copy link
Collaborator

Describe at a high level the solution you're providing
Design Change Requests:

  1. Sensors with no connection should read “Moisture levels not detected. Check connection.”
  2. On the Filters page/section, the link now says “Clear Filters”.
  3. Added a section on the landing page to indicate the sort order. This section should be persistent so that the user can always see the order that the list is sorted in.
  4. When there are no sensors matching a search, the page should display this message (not the default empty state, since that only applies when there are no sensors connected).

Is this a patch, a minor version change, or a major version change
minor

Is this related to an open issue?
https://trello.com/c/oHeqJm0b

@crystalgardner crystalgardner changed the base branch from main to development October 12, 2023 02:39
ilfreedom
ilfreedom approved these changes Oct 25, 2023
View reviewed changes
Copy link
Collaborator

@ilfreedom ilfreedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ilfreedom ilfreedom merged commit dbc71f1 into Liquid-Prep:development Oct 25, 2023
Keneweab pushed a commit that referenced this pull request Oct 27, 2023
@crystalgardner @Keneweab
Sensors landing page updates (#52)
e4cf22c 
* Design change requests

* fix sorted by display bug

* Design change requests

* fix sorted by display bug
Keneweab pushed a commit that referenced this pull request Nov 12, 2023
@crystalgardner @Keneweab
Sensors landing page updates (#52)
53084df 
* Design change requests

* fix sorted by display bug

* Design change requests

* fix sorted by display bug
Keneweab pushed a commit that referenced this pull request Nov 12, 2023
@crystalgardner @Keneweab
Sensors landing page updates (#52)
386c6a9 
* Design change requests

* fix sorted by display bug

* Design change requests

* fix sorted by display bug
Keneweab pushed a commit that referenced this pull request Nov 12, 2023
@crystalgardner @Keneweab
Sensors landing page updates (#52)
6bd21a2 
* Design change requests

* fix sorted by display bug

* Design change requests

* fix sorted by display bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilfreedom ilfreedom ilfreedom approved these changes

@Gaurav-Ramakrishna Gaurav-Ramakrishna Awaiting requested review from Gaurav-Ramakrishna

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crystalgardner @ilfreedom