Open
Conversation
|
@Elite-tch Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Contributor
Author
|
Sorry for late PR |
Contributor
Author
|
@Babigdk please my pr is still pending |
Contributor
|
@Elite-tch Please resolve the conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description: Escrow Service Integration
Title: feat(api): integrate escrow route with Soroban service adapter
Closes #5
Summary Implemented the Soroban escrow integration layer and connected the API boundary to the blockchain service.
Key Changes:
Escrow Service: Created src/services/escrow.service.js to abstract Soroban contract reads/writes with built-in retry resilience.
Route Wiring: Connected GET /api/escrow/:invoiceId to the service layer with Zod response validation.
Boundary Hardening: Refactored auth.js to use AppError, ensuring consistent RFC 7807 error shapes for all unauthorized requests.
Testing: Added unit and integration tests for escrow logic.