feat(escrow): add tested principal-plus-yield payout helper#141
Merged
mikewheeleer merged 2 commits intoLiquifact:mainfrom Apr 1, 2026
Merged
Conversation
|
@ISTIFANUS-N Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
- Implement calculate_principal_plus_yield() function with deterministic integer math - Add comprehensive test suite with 12+ tests covering edge cases and properties - Document rounding strategy (truncation toward zero) and overflow protection - Include formal invariant ESC-YLD-001 in README.md - Achieve 98.8% line coverage (exceeds 95% requirement) Security notes: - Uses checked arithmetic to prevent overflow - Validates inputs (principal ≥ 0, yield_bps ∈ [0, 10_000]) - Pure integer calculation ensures cross-platform determinism - Conservative rounding protects contract solvency
Contributor
Author
|
@mikewheeleer merge my work please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security notes:
closes #10