feat(match2): conditionally display objectives in lol matchpage #6078
+19
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjpalpha
approved these changes
Jun 27, 2025
|
Nah, doesn't belong in the frontend. If it should be added, it belongs in the backend |
hjpalpha
approved these changes
Jun 30, 2025
|
I think this belongs to the proper proper backend (ie loldb), we would need to fix it there for the future anyway |
I agree, but that would have to wait until Crossroads migration, right? |
Rathoz
reviewed
Jul 18, 2025
Rathoz
reviewed
Sep 7, 2025
ElectricalBoy
force-pushed
the
lol-matchpage-new-stats-in-new-games-only
branch
from
d4b09b6 to
eace774
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#6076 added stats for heralds, void grubs and atakhan to LoL match pages. However, for older matches that were played before some of these objectives were introduced, it only introduces redundant rows that do nothing.
This PR adds match date-based conditions to suppress display of objectives that were not present at the time of match.
How did you test this change?
dev: https://liquipedia.net/leagueoflegends/Match:ID_User_ElectricalBoy_zqx7pe0nDj_R01-M001