refactor(infobox): use StandardPatch in PatchAuto extension #6353
Conversation
| conditions = '[[type::patch]] AND [[pagename::' .. patch .. ']]', | ||
| query = 'name', | ||
| local patchData = Patch.queryPatches{ | ||
| additionalConditions = ConditionNode(ColumnName('pagename'), Comparator.eq, patch:gsub(' ', '_')), |
There was a problem hiding this comment.
Is it correct to query this by pagename? I would have assumed that the patch input is a version? or am I wrong here?
There was a problem hiding this comment.
fwiw stormgate is the only wiki taking advantage of this extension and they do use pagename as patch input for whatever reason
you are right on patch input being a version on most wikis but stormgate doesn't seem to be one of them ¯\_(ツ)_/¯
There was a problem hiding this comment.
Should we bot fix this on stormgate and use versio number instead?
There was a problem hiding this comment.
not against it, but they don't use a numeric system for patch either; see stormgate:Special:PrefixIndex/Patch
so I don't think it would be a straightforward bot job :(
There was a problem hiding this comment.
as long as version is unique you can use that, right?
and iirc they always have the version as last part of the pagename, so bot job should be able to just replace the input params, right?
There was a problem hiding this comment.
and iirc they always have the version as last part of the pagename, so bot job should be able to just replace the input params, right?
oh right that does seem to be the pattern
There was a problem hiding this comment.
Let's update SG Tournament Pages, or?
Summary
This PR updates PatchAuto extension to use
StandardPatchfor querying.How did you test this change?
preview with dev